Review main Merged

48811[BUGFIX] Adodb: PHP 7.1 compatibility

Christian Kuhn CR +2 V +2 Easy +0 −4 updated 07/05/16, 20:29

Commit message

unset($this) throws a fatal if linting with PHP 7.1.
According to php.net/unset the construct isn't allowed since
PHP 5. Now the linter stumbles upon that, too.
Solution is to drop these calls, the according files and
classes from adodb are not used by our dbal integration anyway.
A pull request to upstream is pending for this, too, but we
never know when it will be merged. Should be safe to do that
locally in our adapted version.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Wouter Wolters +1
  • Verified V +2
    • Frank Nägler +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 78

  1. Christian Kuhn uploaded patch set 1 07/05/16, 19:31

  2. TYPO3com voted on patch set 1 V +1 07/05/16, 19:34 Completed build in 02m 31s on Tue, 5 Jul, 09:34 PM Test Summary: 9651 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-473

  3. Christian Kuhn commented on patch set 1 07/05/16, 19:43

    php 7.1 linter red without patch: https://bamboo.typo3.com/browse/CORE-TL-LOLLILP-44 php 7.1 linter green with patch: https://bamboo.typo3.com/browse/CORE-TL-LOLLILP-45
  4. Wouter Wolters voted on patch set 1 CR +1 V +1 07/05/16, 19:45

  5. Frank Nägler voted on patch set 1 CR +1 V +1 07/05/16, 20:28

  6. Frank Nägler voted on patch set 1 CR +2 V +2 07/05/16, 20:28

  7. Gerrit merged patch set 1 07/05/16, 20:28

  8. Frank Nägler commented on patch set 2 07/05/16, 20:29

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit a85c9598d0d1895073020d3e6166ec8f130ffb4f