48813[BUGFIX] PHP 7.1: Non-numeric value encountered
Commit message
Review
-
Code review CR +2
- Steffen Müller +2
- Markus Klein +1
-
Verified V +2
- Steffen Müller +2
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1315
-
Christian Kuhn uploaded patch set 1 07/05/16, 21:33
-
Christian Kuhn commented on patch set 1 07/05/16, 21:35
-
TYPO3com voted on patch set 1 V +1 07/05/16, 21:36 Completed build in 02m 40s on Tue, 5 Jul, 11:36 PM Test Summary: 9651 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-477
-
Wouter Wolters voted on patch set 1 CR +1 V +1 07/05/16, 21:41
-
Markus Klein commented on patch set 1 07/06/16, 08:06
IntegerFilterTest.php:38ReplyI'm lacking knowhow what the original test was supposed to validate. So I can't judge on the equality of the new test. -
Christian Kuhn commented on patch set 1 07/06/16, 08:37
IntegerFilterTest.php:38Replyactually, the test subject first casts to string, then to int. both input (with + without patch) lead to the same result int 1: $foo = 1+'E42'; var_dump((int)((string)$foo)); $bar = '1+E42'; var_dump((int)((string)$bar)); php foo.php int(1) int(1) -
Markus Klein commented on patch set 1 07/06/16, 09:18
After a quick talk with Christian, we decided to kick the line in question as it tests PHP functionality and not ours. -
Christian Kuhn uploaded patch set 2 07/06/16, 09:22
-
TYPO3com voted on patch set 2 V +1 07/06/16, 09:24 Completed build in 02m 47s on Wed, 6 Jul, 11:24 AM Test Summary: 9663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-488
-
Markus Klein voted on patch set 2 CR +1 V +1 07/06/16, 09:29
-
Steffen Müller voted on patch set 2 CR +1 V +1 07/06/16, 11:02
-
Steffen Müller voted on patch set 2 CR +2 V +2 07/06/16, 11:05
-
Gerrit merged patch set 2 07/06/16, 11:05
-
Stephan Großberndt commented on patch set 3 08/18/16, 12:05
Backport to 7.6 is missing. please add a note to the review if this is not going to be backported. -
Markus Klein commented on patch set 3 08/18/16, 12:47
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit d68ae26e93eba978403c6b1e926a999a9ee54775
IntegerFilterTest.php:38