Review TYPO3_4-5 Merged

4882[TASK] EM: make pop-up window use full screen

Francois Suter CR +2 V +2 Easy +1 −2 updated 06/03/13, 20:49

Commit message

The information pop-up window in the Extension Manager is hard-coded
to some reduced size. Make it use the full screen instead, as it is
modal anyway. This provides more space to view all the information.

Review

  • Code review CR +2
    • Francois Suter +2
    • Markus Klein +1
    • Oliver Hader +1
    • Susi Moog +1
    • Philipp Gampe +1
  • Verified V +2
    • Francois Suter +2
    • Markus Klein +1
    • Oliver Hader +1
    • Susi Moog +1
    • Philipp Gampe +1

Issues 1

Files 1

Review log 11

  1. Markus Klein commented on patch set 1 03/11/12, 18:15

    Verified; Looks good to me, but someone else must approve
  2. Francois Suter commented on patch set 2 03/11/12, 18:15

    This one would have enough votes to be merged, but I have misgivings about it. Although I think this is a real usability improvement for the new EM, it also represents a change of UI which is maybe not appropriate in a stable branch. Any opinions about this? Should it be merged or abandoned?
  3. Markus Klein commented on patch set 2 03/11/12, 18:15

    Verified; Looks good to me, but someone else must approve
  4. Markus Klein commented on patch set 2 03/11/12, 18:15

    Definitely YES. Merge it. Besides that it has been merged to 4.6 already with this commit message (announcing it for 4.5), so these thoughts should have been made before that merge.
  5. Susi Moog commented on patch set 2 03/11/12, 18:15

    Verified; Looks good to me, but someone else must approve I'd also say go ahead and merge it.
  6. Oliver Hader uploaded patch set 2 03/11/12, 18:15

  7. Oliver Hader commented on patch set 2 03/11/12, 18:15

    Verified; Looks good to me, but someone else must approve Automated rebasing to TYPO3_4-5 - Please consider updating your reviews V:1, R:1 as a summary of previous scores (limited to [-1;+1]) V:1, R:1 from Markus Klein <klein.t3@mfc-linz.at>
  8. Philipp Gampe commented on patch set 2 03/11/12, 18:15

    Verified; Looks good to me, but someone else must approve
  9. Mr. Jenkins commented on patch set 1 03/11/12, 18:15

  10. Francois Suter commented on patch set 2 V 0 03/11/12, 18:15

    by team member; Looks good to me, approved
  11. Francois Suter merged patch set 2 03/11/12, 18:15