Review main Merged

48841[BUGFIX] PHP 7.1 unit tests

Christian Kuhn CR +2 V +2 Normal +31 −28 updated 07/07/16, 12:10

Commit message

Fix a couple of unit tests that fail with PHP 7.1:

* The phpunit mock builder seems to have minor issues mocking
mysqli correctly. This leads so slightly different method
signatures and PHP 7.1 is a bit more picky about those details.
Switching to prophecy on affected tests solves the issue.

* $tsfe->config is initialized as string, calling
$tsfe->config['foo']['bar'] = 'baz'; raises an error
"Error: Cannot use assign-op operators with string offsets".
Cleaning the assignment solves the issue.

Review

  • Code review CR +2
    • Benni Mack +2
    • Sebastian Bumann +1
  • Verified V +2
    • Benni Mack +2
    • Sebastian Bumann +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 913

  1. Christian Kuhn uploaded patch set 1 07/07/16, 11:25

  2. TYPO3com voted on patch set 1 V +1 07/07/16, 11:28 Completed build in 03m 08s on Thu, 7 Jul, 01:28 PM Test Summary: 9672 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-564

  3. Christian Kuhn updated the commit message in patch set 2 07/07/16, 11:29

  4. Christian Kuhn commented on patch set 2 07/07/16, 11:30

    php 7.1 unit tests are green now: https://bamboo.typo3.com/browse/CORE-TL-LOLLIUTP-85
  5. TYPO3com voted on patch set 2 V +1 07/07/16, 11:33 Completed build in 03m 14s on Thu, 7 Jul, 01:33 PM Test Summary: 9672 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-565

  6. Sebastian Bumann updated the commit message in patch set 3 07/07/16, 11:46

  7. Sebastian Bumann updated the commit message in patch set 4 07/07/16, 11:48

  8. TYPO3com voted on patch set 3 V +1 07/07/16, 11:51 Completed build in 04m 59s on Thu, 7 Jul, 01:51 PM Test Summary: 9672 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-568

  9. Sebastian Bumann voted on patch set 4 CR +1 07/07/16, 11:53

  10. TYPO3com voted on patch set 4 V +1 07/07/16, 11:54 Completed build in 05m 34s on Thu, 7 Jul, 01:54 PM Test Summary: 9672 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-569

  11. Sebastian Bumann voted on patch set 4 V +1 07/07/16, 11:59

  12. Benni Mack voted on patch set 4 CR +2 V +2 07/07/16, 12:10

  13. Gerrit merged patch set 4 07/07/16, 12:10