Review main Merged

48846[TASK] Remove direct usage of mb_ methods in the core

Georg Ringer CR +2 V +2 Easy +3 −5 updated 07/09/16, 14:02

Commit message

As mbstring is not a requirement, remove the usage of its
methods in the core.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Frans Saris +1
    • Mathias Brodala +1
  • Verified V +2
    • Christian Kuhn +2
    • Frans Saris +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 89

  1. Georg Ringer uploaded patch set 1 07/07/16, 17:40

  2. Georg Ringer commented on patch set 1 07/07/16, 17:40

    adding mbstring in require-dev should be done in seperate commit
  3. TYPO3com voted on patch set 1 V +1 07/07/16, 17:43 Completed build in 03m 34s on Thu, 7 Jul, 07:43 PM Test Summary: 18388 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-589

  4. Mathias Brodala voted on patch set 1 CR +1 07/08/16, 07:22

  5. Frans Saris voted on patch set 1 CR +1 V +1 07/08/16, 07:34

  6. Christian Kuhn commented on patch set 1 CR -1 07/09/16, 13:54

    MailMessage.php:257

    this was introduced in https://review.typo3.org/#/c/43294/1 patch set 1 came with if (!preg_match('/^[a-z0-9.\\-]*$/i', $domain)) { before it was changed to mb_check_encoding() maybe we should roll-back to that version instead of removing the call altogether?
  7. Christian Kuhn commented on patch set 1 CR 0 07/09/16, 13:57

    MailMessage.php:257 Reply

    ah, idnaEncode just returns $domain as is if no encoding is needed ... so, just be safe to just always call it.
  8. Christian Kuhn voted on patch set 1 CR +2 V +2 07/09/16, 14:02

  9. Gerrit merged patch set 1 07/09/16, 14:02