Review main Merged Breaking

48847[!!!][TASK] Remove deprecated usage of 'static_lang_isocode'

Christian Kuhn CR +2 V +2 Normal +3 −62 updated 07/08/16, 15:54

Commit message

Remove another usage of static_lang_isocode within FormEngine code.
This field was deprecated in v7 and came along with an update wizard,
it has been marked as breaking in an 8.0 .rst file already.
There are further usages of this field that are harder to remove,
those can be done with other dedicated patches.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Markus Klein +1
  • Verified V +2
    • Frank Nägler +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1217

  1. Christian Kuhn uploaded patch set 1 07/07/16, 19:39

  2. Christian Kuhn updated the commit message in patch set 2 07/07/16, 19:39

  3. Markus Klein voted on patch set 2 CR +1 07/07/16, 19:42

  4. Markus Klein commented on patch set 2 CR 0 07/07/16, 19:45

    DatabaseSystemLanguageRows.php:75

    remove here as well
  5. Markus Klein commented on patch set 3 07/07/16, 19:45

    Published edit on patch set 2.
  6. TYPO3com voted on patch set 1 V -1 07/07/16, 19:46 Completed build in 07m 29s on Thu, 7 Jul, 09:46 PM Test Summary: 18406 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-598

  7. Markus Klein commented on patch set 4 07/07/16, 19:52

    Published edit on patch set 3.
  8. TYPO3com voted on patch set 2 V -1 07/07/16, 19:52 Completed build in 12m 57s on Thu, 7 Jul, 09:52 PM Test Summary: 18406 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-599

  9. TYPO3com voted on patch set 3 V -1 07/07/16, 19:58 Completed build in 13m 11s on Thu, 7 Jul, 09:58 PM Test Summary: 4 of 18406 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-600

  10. Christian Kuhn uploaded patch set 5 07/07/16, 19:59

  11. TYPO3com voted on patch set 4 V -1 07/07/16, 20:04 Completed build in 12m 11s on Thu, 7 Jul, 10:04 PM Test Summary: 18406 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-601

  12. TYPO3com voted on patch set 5 V +1 07/07/16, 20:07 Completed build in 07m 39s on Thu, 7 Jul, 10:07 PM Test Summary: 18406 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-602

  13. Markus Klein voted on patch set 5 CR +1 V +1 07/07/16, 20:07

  14. Frank Nägler voted on patch set 5 CR +1 07/08/16, 15:51

  15. Frank Nägler voted on patch set 5 V +1 07/08/16, 15:54

  16. Frank Nägler voted on patch set 5 CR +2 V +2 07/08/16, 15:54

  17. Gerrit merged patch set 5 07/08/16, 15:54