48850[BUGFIX] Category based file collections should respect translation of metadata
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 2433
Show 58 earlier messages
-
Frans Saris uploaded patch set 1 07/08/16, 08:32
-
TYPO3com voted on patch set 1 V -1 07/08/16, 08:35 Completed build in 03m 41s on Fri, 8 Jul, 10:35 AM Test Summary: 18406 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-610
-
Frans Saris uploaded patch set 2 07/08/16, 08:43
-
TYPO3com voted on patch set 2 V +1 07/08/16, 08:47 Completed build in 03m 30s on Fri, 8 Jul, 10:47 AM Test Summary: 18406 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-611
-
Benni Mack commented on patch set 2 09/09/17, 21:47
This one won't work anymore with the "DISTINCT" part. Care to update the patch? -
Mathias Schreiber uploaded patch set 3 02/06/18, 18:46
-
TYPO3com voted on patch set 3 V +1 02/06/18, 18:55 Completed build in 08m 09s on Tue, 6 Feb, 07:55 PM Test Summary: 30440 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19026
-
Jörg Bösche voted on patch set 3 CR +1 02/12/18, 10:40
-
Tobi Kretschmann voted on patch set 3 CR +1 02/12/18, 10:57
-
Georg Ringer commented on patch set 3 CR -1 02/12/18, 16:09
Unresolved
please improve commit msg titleCategoryBasedFileCollection.php:106Unresolvedwhy should it be empty? if not FE, check typo3_mode. pls add return type -
Jörg Bösche uploaded patch set 4 03/06/18, 13:30
-
TYPO3com voted on patch set 4 V +1 03/06/18, 13:39 Completed build in 08m 33s on Tue, 6 Mar, 02:39 PM Test Summary: 30806 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20577
-
Tobi Kretschmann voted on patch set 4 CR +1 03/06/18, 13:53
-
Mathias Schreiber voted on patch set 4 V +1 CR +1 03/07/18, 17:45
-
Benni Mack commented on patch set 4 CR -1 03/08/18, 12:37
Kind of dislike this approach --- it introduces the issue that this class in EXT:core relies on TSFE (in EXT:frontend) === only possible to use this code in FE context. -
Jörg Bösche commented on patch set 4 03/26/18, 08:49
> Kind of dislike this approach --- it introduces the issue that this > class in EXT:core relies on TSFE (in EXT:frontend) === only > possible to use this code in FE context. Do you have any solution to resolve the dependecy to the TSFE? -
Frans Saris commented on patch set 4 05/17/18, 05:32
@Benni is there a other place in the core where we can fetch the current selected/set sys_language_uid? As far as I know it's only available in TSFE. -
Jörg Bösche commented on patch set 4 08/15/18, 19:48
Ping. :-) Who can patch/resolve the FE dependency for me? -
Benni Mack commented on patch set 4 11/19/18, 09:39
Hey Frans, I'd say we'd need a OUTER JOIN here - what if the metadata hasn't been translated yet for a file? -
Benni Mack updated the commit message in patch set 5 12/14/18, 10:10
-
Benni Mack commented on patch set 5 12/14/18, 10:10
Updated the releases line, please re-apply your votes -
TYPO3com voted on patch set 5 V +1 12/14/18, 11:39 Completed build in 44m 09s on Fri, 14 Dec, 12:39 PM Test Summary: 48757 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30706
-
Andreas Kienast rebased onto patch set 6 12/06/19, 12:19
-
TYPO3com voted on patch set 6 V -1 12/06/19, 12:27 Completed build in 07m 15s on Fri, 6 Dec, 12:27 PM Test Summary: 68753 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39149
-
TYPO3com voted on patch set 6 V +1 12/06/19, 12:41 Completed build in 28m 57s on Fri, 6 Dec, 12:41 PM Test Summary: 68763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39149
-
Benni Mack commented on patch set 6 CR -1 12/10/19, 11:34
CategoryBasedFileCollection.php:66Unresolvedwe should use the Context API now. Also with fallbacks. -
Jörg Bösche uploaded patch set 7 01/13/20, 14:33
-
TYPO3com voted on patch set 7 V +1 01/13/20, 14:42 Completed build in 08m 26s on Mon, 13 Jan, 02:42 PM Test Summary: 69206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39864
-
Susi Moog commented on patch set 7 03/20/20, 14:20
Maybe I'm missing something, but are configured fallbacks taken into account now? -
Benni Mack uploaded patch set 8 08/07/20, 15:47
-
TYPO3com voted on patch set 8 V +1 08/07/20, 16:00 Completed build in 12m 29s on Fri, 7 Aug, 03:59 PM Test Summary: 72971 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4486
-
Jörg Bösche voted on patch set 8 CR +1 09/11/20, 09:57
-
Benni Mack abandoned the change 11/10/21, 11:20
abandoning this change. There is no activity in the last 18 months, and no feedback on the last comments. Can be restored later.