4886[TASK] EM: maintenance tab suggest download of CF tables
Commit message
Review
-
Code review CR +2
- Xavier Perseguers +2
- Helmut Hummel +1
- Philipp Gampe +1
-
Verified V +2
- Xavier Perseguers +2
- Helmut Hummel +1
- Philipp Gampe +1
Issues 1
Files 3
Review log 11
-
Francois Suter commented on patch set 1 09/10/11, 18:15
Note: this patch includes some small cleanups, mostly related to phpDoc, just so that my IDE stopped complaining while trying to solve the issue. -
Xavier Perseguers commented on patch set 1 09/10/11, 18:15
Verified; Looks good to me, but someone else must approve -
Xavier Perseguers commented on patch set 2 V 0 09/10/11, 18:15
by team member; Looks good to me, approved -
Helmut Hummel commented on patch set 2 09/10/11, 18:15
Verified; Looks good to me, but someone else must approve Looked good in general and worked. I only did not like the double negation: if (!skipCachingTables) Hope that showChachingTables is also OK for you. -
Helmut Hummel uploaded patch set 2 09/10/11, 18:15
-
Soren Malling voted on patch set 1 V 0 09/10/11, 18:15
-
Philipp Gampe commented on patch set 1 09/10/11, 18:15
Verified; Looks good to me, but someone else must approve Works for me. -
Philipp Gampe commented on patch set 2 09/10/11, 18:15
Verified; Looks good to me, but someone else must approve renewing my vote -
Mr. Jenkins commented on patch set 1 09/10/11, 18:15
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1809/ : SUCCESS -
Mr. Jenkins commented on patch set 2 09/10/11, 18:15
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1823/ : SUCCESS -
Xavier Perseguers merged patch set 2 09/10/11, 18:15