Review main Merged

4886[TASK] EM: maintenance tab suggest download of CF tables

Francois Suter CR +2 V +2 Easy +25 −19 updated 06/03/13, 20:49

Commit message

When looking at an extension's details, the developer information tab
lists all caching framework (CF) tables and the maintenance tab
proposes all CF tables for download. It doesn't make sense, even
for cache tables that are related to the current extension
(because they are created automatically and there's no reason
to dump a cache table's data).
The solution is to add a new flag to avoid listing CF tables
in some circumstances.

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Helmut Hummel +1
    • Philipp Gampe +1
  • Verified V +2
    • Xavier Perseguers +2
    • Helmut Hummel +1
    • Philipp Gampe +1

Issues 1

Files 3

Review log 11

  1. Francois Suter commented on patch set 1 09/10/11, 18:15

    Note: this patch includes some small cleanups, mostly related to phpDoc, just so that my IDE stopped complaining while trying to solve the issue.
  2. Xavier Perseguers commented on patch set 1 09/10/11, 18:15

    Verified; Looks good to me, but someone else must approve
  3. Xavier Perseguers commented on patch set 2 V 0 09/10/11, 18:15

    by team member; Looks good to me, approved
  4. Helmut Hummel commented on patch set 2 09/10/11, 18:15

    Verified; Looks good to me, but someone else must approve Looked good in general and worked. I only did not like the double negation: if (!skipCachingTables) Hope that showChachingTables is also OK for you.
  5. Helmut Hummel uploaded patch set 2 09/10/11, 18:15

  6. Soren Malling voted on patch set 1 V 0 09/10/11, 18:15

  7. Philipp Gampe commented on patch set 1 09/10/11, 18:15

    Verified; Looks good to me, but someone else must approve Works for me.
  8. Philipp Gampe commented on patch set 2 09/10/11, 18:15

    Verified; Looks good to me, but someone else must approve renewing my vote
  9. Mr. Jenkins commented on patch set 1 09/10/11, 18:15

  10. Mr. Jenkins commented on patch set 2 09/10/11, 18:15

  11. Xavier Perseguers merged patch set 2 09/10/11, 18:15