Review main Merged

48902[TASK] Remove explicit tt_track in ExtendedTemplateService

Benni Mack CR +2 V +2 Easy +10 −37 updated 07/11/16, 14:55

Commit message

ExtendedTemplateService for the backend always disables the
timetracker information from the actual funcmodule but could
easily be turned off by default from the actual class itself.

This makes the code easier to read and also removes some
syntax errors from previous cleanups where values and variables
are empty.

Review

  • Code review CR +2
    • Jan Helke +2
    • Anja Leichsenring +1
  • Verified V +2
    • Jan Helke +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 79

  1. Benni Mack uploaded patch set 1 07/11/16, 14:37

  2. TYPO3com voted on patch set 1 V +1 07/11/16, 14:40 Completed build in 03m 26s on Mon, 11 Jul, 04:40 PM Test Summary: 18442 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-755

  3. Anja Leichsenring commented on patch set 2 07/11/16, 14:41

    Published edit on patch set 1.
  4. Jan Helke voted on patch set 2 CR +1 07/11/16, 14:44

  5. TYPO3com voted on patch set 2 V +1 07/11/16, 14:44 Completed build in 03m 16s on Mon, 11 Jul, 04:44 PM Test Summary: 18442 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-756

  6. Anja Leichsenring voted on patch set 2 CR +1 V +1 07/11/16, 14:53

  7. Jan Helke voted on patch set 2 V +1 07/11/16, 14:55

  8. Jan Helke voted on patch set 2 CR +2 V +2 07/11/16, 14:55

  9. Gerrit merged patch set 2 07/11/16, 14:55