Review main Merged Breaking

48922[!!!][TASK] Remove example image in TS constants description

Benni Mack CR +2 V +2 Normal +53 −85 updated 07/14/16, 08:46

Commit message

In TYPO3 it was possible to show an image for a category in
the Constants Editor, if the constants editor had configured a category
like this (also defined in the Constants Editor):

TSConstantEditor.basic.image = EXT:sys_note/ext_icon.png

As the functionality is hardly used and better options for styling
and displaying images e.g. via user functions is possible, the
image option has been removed.

With that, the following breaking changes in the related PHP code
happened:
- Removed ExtendedTemplateService::$ext_localGfxPrefix
- Removed ExtendedTemplateService::$ext_localWebGfxPrefix
- Removed ExtendedTemplateService::ext_getTSCE_config_image
- Removed ConfigurationForm::ext_getTSCE_config_image
- Dropped parameter 2+3 of ConfigurationForm::ext_initTSstyleConfig

Review

  • Code review CR +2
    • Georg Ringer +2
    • Thomas Schlumberger +1
    • Benni Mack +1
  • Verified V +2
    • Georg Ringer +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1318

  1. Benni Mack uploaded patch set 1 07/12/16, 09:57

  2. Benni Mack uploaded patch set 2 07/12/16, 10:00

  3. TYPO3com voted on patch set 1 V -1 07/12/16, 10:10 Completed build in 12m 45s on Tue, 12 Jul, 12:10 PM Test Summary: 18450 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-826

  4. Benni Mack uploaded patch set 3 07/12/16, 10:16

  5. TYPO3com voted on patch set 2 V +1 07/12/16, 10:22 Completed build in 21m 14s on Tue, 12 Jul, 12:22 PM Test Summary: 18450 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-829

  6. TYPO3com voted on patch set 3 V +1 07/12/16, 10:40 Completed build in 24m 10s on Tue, 12 Jul, 12:40 PM Test Summary: 18450 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-835

  7. Frederic Gaus voted on patch set 3 CR +1 07/12/16, 13:44

  8. Andreas Kienast commented on patch set 3 CR -1 07/12/16, 16:02

    on it
  9. Andreas Kienast uploaded patch set 4 07/12/16, 16:05

  10. Andreas Kienast voted on patch set 4 CR +1 07/12/16, 16:06

  11. TYPO3com voted on patch set 4 V -1 07/12/16, 16:08 Completed build in 03m 08s on Tue, 12 Jul, 06:08 PM Test Summary: 18450 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-875

  12. Andreas Kienast uploaded patch set 5 07/12/16, 16:11

  13. TYPO3com voted on patch set 5 V +1 07/12/16, 16:17 Completed build in 05m 09s on Tue, 12 Jul, 06:17 PM Test Summary: 18450 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-877

  14. Benni Mack voted on patch set 5 CR +1 V +1 07/12/16, 16:26

  15. Thomas Schlumberger voted on patch set 5 CR +1 07/14/16, 07:05

  16. Georg Ringer voted on patch set 5 CR +2 V +2 07/14/16, 08:46

  17. Gerrit merged patch set 5 07/14/16, 08:46

  18. Oliver Klee commented on patch set 5 07/14/16, 08:46

    ConfigurationForm.php:69

    Should/can we also remove these two fields?