Review main Merged

48923[TASK] Move arguments to initializeArguments() in HtmlVH in ext:fluid

Roberto Torresani CR +2 V +2 Easy +13 −2 updated 07/19/16, 05:20

Commit message

Move the argument registrations away from the render() method
to initializeArguments(), to prevent any errors with PHP7 and
subclassed ViewHelpers if/when render() method signatures change

Review

  • Code review CR +2
    • Susi Moog +2
    • Anna Färber +1
    • Jörg Bösche +1
  • Verified V +2
    • Susi Moog +2
    • Anna Färber +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Roberto Torresani uploaded patch set 1 07/12/16, 09:59

  2. TYPO3com voted on patch set 1 V +1 07/12/16, 10:17 Completed build in 18m 21s on Tue, 12 Jul, 12:17 PM Test Summary: 18450 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-828

  3. Anna Färber voted on patch set 1 CR +1 V +1 07/12/16, 12:38

  4. Jörg Bösche voted on patch set 1 CR +1 V +1 07/18/16, 18:46

  5. Susi Moog voted on patch set 1 CR +2 V +2 07/19/16, 05:20

  6. Gerrit merged patch set 1 07/19/16, 05:20