Review main Merged

48925[TASK] Move arguments to initializeArguments() in PaddingVH in ext:fluid

Roberto Torresani CR +2 V +2 Normal +89 −18 updated 07/15/16, 18:31

Commit message

Move the argument registrations away from the render() method
to initializeArguments(), to prevent any errors with PHP7 and
subclassed ViewHelpers if/when render() method signatures change.
Change the UnitTest PaddingViewHelperTest with setArguments()

Review

  • Code review CR +2
    • Susi Moog +2
    • Anja Leichsenring +1
  • Verified V +2
    • Susi Moog +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Roberto Torresani uploaded patch set 1 07/12/16, 10:12

  2. TYPO3com voted on patch set 1 V +1 07/12/16, 10:30 Completed build in 18m 41s on Tue, 12 Jul, 12:30 PM Test Summary: 18450 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-832

  3. Anja Leichsenring uploaded patch set 2 07/12/16, 19:07

  4. Anja Leichsenring voted on patch set 2 CR +1 V +1 07/12/16, 19:08

  5. TYPO3com voted on patch set 2 V +1 07/12/16, 19:15 Completed build in 07m 01s on Tue, 12 Jul, 09:15 PM Test Summary: 18452 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-888

  6. Anja Leichsenring commented on patch set 2 CR -1 07/13/16, 07:32

    on it, want to add a test class
  7. Anja Leichsenring commented on patch set 2 CR +1 07/13/16, 07:36

    ... wrong patch, sorry :D
  8. Susi Moog voted on patch set 2 CR +2 V +2 07/15/16, 18:30

  9. Gerrit merged patch set 2 07/15/16, 18:31