Review main Merged

48929[TASK] Move arguments to initializeArguments() in CObjectVH in ext:fluid

Roberto Torresani CR +2 V +2 Normal +200 −11 updated 07/20/16, 09:30

Commit message

Move the argument registrations away from the render() method
to initializeArguments(), to prevent any errors with PHP7 and
subclassed ViewHelpers if/when render() method signatures change.

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Wouter Wolters +1
  • Verified V +2
    • Nicole Hummel +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1319

  1. Roberto Torresani uploaded patch set 1 07/12/16, 11:11

  2. TYPO3com voted on patch set 1 V +1 07/12/16, 11:25 Completed build in 13m 54s on Tue, 12 Jul, 01:25 PM Test Summary: 18450 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-849

  3. Anja Leichsenring commented on patch set 1 CR -1 07/13/16, 07:36

    on it, want to add a test class
  4. Anja Leichsenring uploaded patch set 2 07/13/16, 07:43

  5. TYPO3com voted on patch set 2 V -1 07/13/16, 07:47 Completed build in 03m 31s on Wed, 13 Jul, 09:47 AM Test Summary: 8 of 18458 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-907

  6. Anja Leichsenring uploaded patch set 3 07/13/16, 08:47

  7. TYPO3com voted on patch set 3 V -1 07/13/16, 08:51 Completed build in 03m 12s on Wed, 13 Jul, 10:50 AM Test Summary: 878 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-909

  8. Anja Leichsenring uploaded patch set 4 07/13/16, 09:21

  9. TYPO3com voted on patch set 4 V +1 07/13/16, 09:24 Completed build in 03m 24s on Wed, 13 Jul, 11:24 AM Test Summary: 18462 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-910

  10. Gleb Levitin uploaded patch set 5 07/19/16, 10:15

  11. TYPO3com voted on patch set 5 V +1 07/19/16, 10:21 Completed build in 05m 19s on Tue, 19 Jul, 12:21 PM Test Summary: 19306 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1090

  12. Nicole Hummel voted on patch set 5 CR +1 V +1 07/19/16, 10:23

  13. Wouter Wolters commented on patch set 5 CR -1 07/19/16, 17:37

    CObjectViewHelperTest.php:22

    phpdoc missing

    CObjectViewHelperTest.php:42

    protected

    CObjectViewHelperTest.php:67

    $this

    CObjectViewHelperTest.php:88

    $this

    CObjectViewHelperTest.php:145

    $this
  14. Wouter Wolters uploaded patch set 6 07/19/16, 17:42

  15. Wouter Wolters voted on patch set 6 CR +1 V +1 07/19/16, 17:43

  16. TYPO3com voted on patch set 6 V +1 07/19/16, 17:47 Completed build in 05m 03s on Tue, 19 Jul, 07:47 PM Test Summary: 19320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1134

  17. Wouter Wolters wrote 07/20/16, 08:58

    Topic set to fluid-argument
  18. Nicole Hummel voted on patch set 6 CR +2 V +2 07/20/16, 09:30

  19. Gerrit merged patch set 6 07/20/16, 09:30