Review main Merged

4893[TASK] EM: move "upload t3x" to tab Remote Repository

Xavier Perseguers CR +2 V +2 Easy +11 −10 updated 06/03/13, 20:49

Commit message

In an attempt to have the Remote Repository tab become a place to
search and install new extensions, the tiny upload .t3x icon next
to the filter textbox in "Local Extension List" should be moved.

Review

  • Code review CR +2
    • Steffen Gebert +2
    • Markus Klein +1
  • Verified V +2
    • Steffen Gebert +2
    • Markus Klein +1
    • Soren Malling +1

Issues 1

Files 2

Review log 12

  1. Francois Suter commented on patch set 1 09/17/11, 18:46

    I don't think that it's "more lost" than before. However I agree that a text might help.
  2. Francois Suter commented on patch set 1 09/17/11, 18:46

    Verified; Looks good to me, but someone else must approve
  3. Philipp Gampe commented on patch set 1 09/17/11, 18:46

    The icon is a little bit lost now... I would have never thought that it does what it does. Maybe it should have text, or at least another bar on the right site (like the one just left too it).
  4. Markus Klein commented on patch set 2 09/17/11, 18:46

    Verified; Looks good to me, but someone else must approve
  5. Xavier Perseguers commented on patch set 2 09/17/11, 18:46

    Actually, "moving" is exactly what it is all about. Of course making the interface better is hopefully to be done as well.
  6. Steffen Gebert commented on patch set 2 V 0 09/17/11, 18:46

    by team member; Looks good to me, approved
  7. Soren Malling commented on patch set 2 V 0 09/17/11, 18:46

    I can give +1 for the movement of the button, but I would like to see a review for a more visible upload button (a label next to the icon ex.) - this +1 is given for the purpose of moving the "upload" button
  8. Philipp Gampe uploaded patch set 2 09/17/11, 18:46

  9. Philipp Gampe commented on patch set 2 09/17/11, 18:46

    I just added another bar on right.
  10. Mr. Jenkins commented on patch set 1 09/17/11, 18:46

  11. Mr. Jenkins commented on patch set 2 09/17/11, 18:46

  12. Steffen Gebert merged patch set 2 09/17/11, 18:46