Review main Merged Breaking

48933[!!!][TASK] Remove legacy soft references functionality

Benni Mack CR +2 V +2 Hard +209 −219 updated 07/28/16, 06:06

Commit message

The soft references based on TSconfig, TStemplate and images within
fileadmin/ are not accurate and thus useless since it's not common
anymore to reference TSconfig or TStemplate code inline inside the
DB fields, and also the data inside the softrefparser hasn't been used
anymore.

In order to refactor the SoftReference Index the old legacy code is
removed first without substitution.

The following softref keys are not evaluated anymore:
* TSconfig
* TStemplate

and can be removed from TCA.

The "image" soft reference key is not evaluating files within
fileadmin/ anymore (that are not linked as files).

The "typolink" and "typolink_tag" soft reference parsers don't evalute
links to plain files within fileadmin/ anymore.

The public property "SoftReferenceIndex::$fileAdminDir" is removed.

The following PHP methods are removed without substitution:
* SoftReferenceIndex::findRef_TStemplate()
* SoftReferenceIndex::findRef_TSconfig()
* SoftReferenceIndex::fileadminReferences()

Review

  • Code review CR +2
    • Benni Mack +2
    • Georg Ringer +1
    • Wouter Wolters +1
  • Verified V +2
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 12

Review log 1017

  1. Benni Mack uploaded patch set 1 07/12/16, 16:24

  2. TYPO3com voted on patch set 1 V -1 07/12/16, 16:29 Completed build in 05m 38s on Tue, 12 Jul, 06:29 PM Test Summary: 18450 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-878

  3. Benni Mack uploaded patch set 2 07/14/16, 06:04

  4. TYPO3com voted on patch set 2 V +1 07/14/16, 06:08 Completed build in 03m 27s on Thu, 14 Jul, 08:08 AM Test Summary: 18468 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-930

  5. Benni Mack uploaded patch set 3 07/19/16, 18:24

  6. TYPO3com voted on patch set 3 V -1 07/19/16, 18:45 Completed build in 21m 17s on Tue, 19 Jul, 08:45 PM Test Summary: 18764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1137

  7. Benni Mack uploaded patch set 4 07/19/16, 20:12

  8. TYPO3com voted on patch set 4 V +1 07/19/16, 20:17 Completed build in 03m 58s on Tue, 19 Jul, 10:16 PM Test Summary: 19318 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1153

  9. TYPO3com commented on patch set 3 07/19/16, 23:01 Completed build in 4h 58m 23s on Wed, 20 Jul, 01:01 AM Test Summary: 19318 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1137

  10. Benni Mack uploaded patch set 5 07/20/16, 07:41

  11. TYPO3com voted on patch set 5 V -1 07/20/16, 07:53 Completed build in 06m 29s on Wed, 20 Jul, 09:53 AM Test Summary: 19326 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1171

  12. Benni Mack uploaded patch set 6 07/20/16, 20:46

  13. TYPO3com voted on patch set 6 V +1 07/20/16, 20:52 Completed build in 05m 52s on Wed, 20 Jul, 10:52 PM Test Summary: 19326 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1206

  14. Wouter Wolters voted on patch set 6 CR +1 07/26/16, 12:40

  15. Georg Ringer voted on patch set 6 CR +1 V +1 07/27/16, 17:27

  16. Benni Mack voted on patch set 6 CR +2 V +2 07/28/16, 06:06

  17. Gerrit merged patch set 6 07/28/16, 06:06