4896[TASK] EM: rename local and remote tabs
Commit message
Review
-
Code review CR +2
- Xavier Perseguers +2
- Francois Suter +1
-
Verified V +2
- Xavier Perseguers +2
- Francois Suter +1
- Soren Malling +1
Issues 1
Files 3
Review log 18
-
Francois Suter commented on patch set 1 09/10/11, 21:22
Looks good to me, but someone else must approve We discussed this change quite a bit with Xavier and we feel it's an improvement. The problem of course is that TYPO3's extension installation process has been ambiguously defined for a long time. If you consider it objectively, it's actually a two-step process: 1) make the extension available locally. This is achieved either by downloading it from the TER or uploading it from the file system. 2) activate the extension. Here I would use the word "load", which is appropriate and matches t3lib_extMgm::isLoaded(). I think calling the first tab just "Extensions" is confusing, because the EM is all about extensions. So the wording is not explicit enough. About the second tab, I can agree that the word "install" does not quite fit, since it hints at the second part of the process (which is really "loading" and not "installing") which happens in the fact back in the first tab. However calling "Repository" is bad IMO, since this means nothing in this context, especially taking into account https://review.typo3.org/#change,4893 which moves the t3x upload to that second tab. It really becomes an "import" function. -
Francois Suter commented on patch set 1 09/10/11, 21:22
@Philipp Indeed, new labels since 4.6 require the language cache to be cleared @Helmut I like your proposal -
Xavier Perseguers commented on patch set 1 09/10/11, 21:22
Actually not, "installing" is no more possible from the first tab. You may "load" (or "activate") an extension but not "install" it in the sense given by the EM methods "getInstalledExtensions". The process of installing an extension currently means put the corresponding files within typo3conf/ext (as example). -
Helmut Hummel commented on patch set 1 09/10/11, 21:22
(1 inline comment)locallang.xlf:316I would think that "Import Extensions" would be more appropriate, since installing is also possible in the "Extension List" tab. -
Helmut Hummel commented on patch set 1 09/10/11, 21:22
What does "import" mean then? -
Helmut Hummel commented on patch set 1 09/10/11, 21:22
I mean I'm fine renaming things if it makes more sense from a user perspective. But arguing that the EM method name "installExtension" means something different is a bit weird in my understanding. -
Helmut Hummel commented on patch set 1 09/10/11, 21:22
I'm fine with the following terminology: "Load Extension" (activating an extension which is already present) "Import Extension" (placing the files into the system by the repository or by extension upload) That said I would suggest to name the tabs: Local Extension List -> Available Extensions Remote Repository -> Import Extensions Agreed? -
Francois Suter commented on patch set 2 09/10/11, 21:22
Verified; Looks good to me, but someone else must approve Thanks to all for the excellent discussion leading to this very satisfying result. Great collaboration! -
Xavier Perseguers commented on patch set 2 V 0 09/10/11, 21:22
by team member; Looks good to me, approved -
Xavier Perseguers commented on patch set 2 09/10/11, 21:22
Looks good to me, but someone else must approve -
Helmut Hummel uploaded patch set 2 09/10/11, 21:22
-
Soren Malling commented on patch set 2 V 0 09/10/11, 21:22
I like this renaming very much - a great UX change! -
Philipp Gampe commented on patch set 1 09/10/11, 21:22
Verified; Looks good to me, but someone else must approve A clear all caches is needed to clear l10n cache, but works as expected. -
Felix Kopp commented on patch set 1 09/10/11, 21:22
(1 inline comment)locallang.xlf:316ReplyI think the differentiation between "Local Extensions" and "Repository" would be best. (Reference: http://forge.typo3.org/attachments/17918/em-tabs.png http://forge.typo3.org/issues/27813#change-79175) -
Felix Kopp commented on patch set 1 09/10/11, 21:22
Verified; Looks good to me, but someone else must approve I like that a lot. -
Mr. Jenkins commented on patch set 1 09/10/11, 21:22
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1813/ : SUCCESS -
Mr. Jenkins commented on patch set 2 09/10/11, 21:22
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1824/ : SUCCESS -
Xavier Perseguers merged patch set 2 09/10/11, 21:22