Review main Merged Breaking

48960[!!!][TASK] Remove selectTree options:width,allowRecursiveMode,autoSizeMax

Tymoteusz Motylewski CR +2 V +2 Hard +270 −48 updated 07/20/16, 06:31

Commit message

This patch removes following TCA options related
to 'renderType' => 'selectTree', FormEngine elements:

* ['config']['autoSizeMax']
  starting from now 'size' will be used as max-height

* ['config']['treeConfig']['appearance']['width']
  tree will use up the available space instead

* ['config']['treeConfig']['appearance']['allowRecursiveMode']
  dropped without substitution

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Benni Mack +1
  • Verified V +2
    • Wouter Wolters +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 1318

  1. Tymoteusz Motylewski uploaded patch set 1 07/13/16, 13:47

  2. Tymoteusz Motylewski updated the commit message in patch set 2 07/13/16, 13:49

  3. TYPO3com voted on patch set 1 V -1 07/13/16, 13:54 Completed build in 07m 24s on Wed, 13 Jul, 03:54 PM Test Summary: 18454 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-918

  4. TYPO3com voted on patch set 2 V -1 07/13/16, 13:58 Completed build in 07m 47s on Wed, 13 Jul, 03:58 PM Test Summary: 18454 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-919

  5. Tymoteusz Motylewski uploaded patch set 3 07/13/16, 15:18

  6. TYPO3com voted on patch set 3 V +1 07/13/16, 15:26 Completed build in 07m 50s on Wed, 13 Jul, 05:26 PM Test Summary: 18454 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-920

  7. Jigal van Hemert voted on patch set 3 CR +1 07/13/16, 19:23

  8. Jigal van Hemert voted on patch set 3 V +1 07/13/16, 19:36

  9. Benni Mack commented on patch set 4 07/14/16, 06:17

    Published edit on patch set 3.
  10. Benni Mack commented on patch set 4 07/14/16, 06:18

    Could we use the TCA Migration Tool to throw deprecations when using the options? So we can also make sure they are cleaned before storing in the global TCA array.
  11. TYPO3com voted on patch set 4 V +1 07/14/16, 06:26 Completed build in 09m 17s on Thu, 14 Jul, 08:26 AM Test Summary: 18468 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-931

  12. Tymoteusz Motylewski commented on patch set 4 07/14/16, 07:57

    working on the migration
  13. Tymoteusz Motylewski uploaded patch set 5 07/14/16, 09:08

  14. TYPO3com voted on patch set 5 V +1 07/14/16, 09:16 Completed build in 08m 13s on Thu, 14 Jul, 11:16 AM Test Summary: 18476 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-935

  15. Benni Mack voted on patch set 5 CR +1 V +1 07/19/16, 17:55

  16. Wouter Wolters commented on patch set 5 CR +1 07/19/16, 21:10

    will finalize tomorrow, needs some follow up for ext:styleguide
  17. Wouter Wolters voted on patch set 5 CR +2 V +2 07/20/16, 06:31

  18. Gerrit merged patch set 5 07/20/16, 06:31