48960[!!!][TASK] Remove selectTree options:width,allowRecursiveMode,autoSizeMax
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Benni Mack +1
-
Verified V +2
- Wouter Wolters +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 9
- typo3/sysext/backend/Classes/Form/Element/SelectTreeElement.php+1 −22
- typo3/sysext/backend/Resources/Public/JavaScript/tree.js+0 −18
- typo3/sysext/core/Classes/Category/CategoryRegistry.php+1 −2
- typo3/sysext/core/Classes/Migrations/TcaMigration.php+42 −0
- typo3/sysext/core/Configuration/TCA/be_groups.php+1 −2
- typo3/sysext/core/Configuration/TCA/be_users.php+1 −2
- typo3/sysext/core/Documentation/Changelog/master/Breaking-77081-RemovedTCASelectTreeOptions.rstnew+57 −0
- typo3/sysext/core/Tests/Unit/Migrations/TcaMigrationTest.php+166 −0
- typo3/sysext/frontend/Configuration/TCA/tt_content.php+1 −2
Review log 1318
-
Tymoteusz Motylewski uploaded patch set 1 07/13/16, 13:47
-
Tymoteusz Motylewski updated the commit message in patch set 2 07/13/16, 13:49
-
TYPO3com voted on patch set 1 V -1 07/13/16, 13:54 Completed build in 07m 24s on Wed, 13 Jul, 03:54 PM Test Summary: 18454 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-918
-
TYPO3com voted on patch set 2 V -1 07/13/16, 13:58 Completed build in 07m 47s on Wed, 13 Jul, 03:58 PM Test Summary: 18454 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-919
-
Tymoteusz Motylewski uploaded patch set 3 07/13/16, 15:18
-
TYPO3com voted on patch set 3 V +1 07/13/16, 15:26 Completed build in 07m 50s on Wed, 13 Jul, 05:26 PM Test Summary: 18454 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-920
-
Jigal van Hemert voted on patch set 3 CR +1 07/13/16, 19:23
-
Jigal van Hemert voted on patch set 3 V +1 07/13/16, 19:36
-
Benni Mack commented on patch set 4 07/14/16, 06:17
Published edit on patch set 3. -
Benni Mack commented on patch set 4 07/14/16, 06:18
Could we use the TCA Migration Tool to throw deprecations when using the options? So we can also make sure they are cleaned before storing in the global TCA array. -
TYPO3com voted on patch set 4 V +1 07/14/16, 06:26 Completed build in 09m 17s on Thu, 14 Jul, 08:26 AM Test Summary: 18468 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-931
-
Tymoteusz Motylewski commented on patch set 4 07/14/16, 07:57
working on the migration -
Tymoteusz Motylewski uploaded patch set 5 07/14/16, 09:08
-
TYPO3com voted on patch set 5 V +1 07/14/16, 09:16 Completed build in 08m 13s on Thu, 14 Jul, 11:16 AM Test Summary: 18476 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-935
-
Benni Mack voted on patch set 5 CR +1 V +1 07/19/16, 17:55
-
Wouter Wolters commented on patch set 5 CR +1 07/19/16, 21:10
will finalize tomorrow, needs some follow up for ext:styleguide -
Wouter Wolters voted on patch set 5 CR +2 V +2 07/20/16, 06:31
-
Gerrit merged patch set 5 07/20/16, 06:31