48975[BUGFIX] Prepend current path to versionNumberInFilename RewriteRule
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Markus Klein +1
- Marco Huber +1
-
Verified V +2
- Wouter Wolters +2
- Markus Klein +1
- Marco Huber +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1214
-
Marco Huber uploaded patch set 1 07/14/16, 15:43
-
TYPO3com voted on patch set 1 V +1 07/14/16, 15:46 Completed build in 03m 12s on Thu, 14 Jul, 05:46 PM Test Summary: 18468 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-944
-
Oliver Klee commented on patch set 1 07/14/16, 19:36
Will there be an 8.2.x patchlevel release? Otherwise, it should be only "master, 7.6, 6.2". -
Wouter Wolters updated the commit message in patch set 2 07/14/16, 20:50
-
TYPO3com voted on patch set 2 V +1 07/14/16, 20:55 Completed build in 05m 24s on Thu, 14 Jul, 10:55 PM Test Summary: 19284 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-952
-
Marco Huber voted on patch set 2 CR +1 V +1 07/15/16, 08:53
-
Wouter Wolters commented on patch set 2 07/15/16, 09:15
Marco, your votes won't be counted, as you are the author of the change. -
Marco Huber commented on patch set 2 07/15/16, 09:52
But someone else changed the patch and I verified, that it still works like expected. Ok, this time it was "just" the commit message, but I think I have heard/read somewhere that a +1 from the original author is helpful when the patch changed. -
Markus Klein commented on patch set 2 07/19/16, 17:59
Did you test whether this still works on apache 2.4 as well? -
Markus Klein commented on patch set 2 CR +1 V +1 07/19/16, 18:02
Tested on 2.4 now as well -
Wouter Wolters voted on patch set 2 CR +1 07/19/16, 18:17
-
Wouter Wolters voted on patch set 2 CR +2 V +2 07/19/16, 19:07
-
Gerrit merged patch set 2 07/19/16, 19:08
-
Wouter Wolters commented on patch set 3 07/19/16, 19:08
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit d7c710872fb906a8bd9f61fb35c38f69e0662739