Review main Merged

48975[BUGFIX] Prepend current path to versionNumberInFilename RewriteRule

Marco Huber CR +2 V +2 Easy +1 −1 updated 07/19/16, 19:08

Commit message

For Apache 2.2 the current location is needed in the RewriteRule for the
versionNumberInFilename feature.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
    • Marco Huber +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1
    • Marco Huber +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1214

  1. Marco Huber uploaded patch set 1 07/14/16, 15:43

  2. TYPO3com voted on patch set 1 V +1 07/14/16, 15:46 Completed build in 03m 12s on Thu, 14 Jul, 05:46 PM Test Summary: 18468 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-944

  3. Oliver Klee commented on patch set 1 07/14/16, 19:36

    Will there be an 8.2.x patchlevel release? Otherwise, it should be only "master, 7.6, 6.2".
  4. Wouter Wolters updated the commit message in patch set 2 07/14/16, 20:50

  5. TYPO3com voted on patch set 2 V +1 07/14/16, 20:55 Completed build in 05m 24s on Thu, 14 Jul, 10:55 PM Test Summary: 19284 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-952

  6. Marco Huber voted on patch set 2 CR +1 V +1 07/15/16, 08:53

  7. Wouter Wolters commented on patch set 2 07/15/16, 09:15

    Marco, your votes won't be counted, as you are the author of the change.
  8. Marco Huber commented on patch set 2 07/15/16, 09:52

    But someone else changed the patch and I verified, that it still works like expected. Ok, this time it was "just" the commit message, but I think I have heard/read somewhere that a +1 from the original author is helpful when the patch changed.
  9. Markus Klein commented on patch set 2 07/19/16, 17:59

    Did you test whether this still works on apache 2.4 as well?
  10. Markus Klein commented on patch set 2 CR +1 V +1 07/19/16, 18:02

    Tested on 2.4 now as well
  11. Wouter Wolters voted on patch set 2 CR +1 07/19/16, 18:17

  12. Wouter Wolters voted on patch set 2 CR +2 V +2 07/19/16, 19:07

  13. Gerrit merged patch set 2 07/19/16, 19:08

  14. Wouter Wolters commented on patch set 3 07/19/16, 19:08

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit d7c710872fb906a8bd9f61fb35c38f69e0662739