Review main Merged

4898[BUGFIX] Show extension configuration after extension update

Helmut Hummel CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

When updating an extension, updates of database tables are not
shown and not offered to be updated. Thus they remain unnoticed
and this leads to unexpected results.

Show extension configuration and database updates after updating an extension.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Philipp Gampe +1
  • Verified V +2
    • Georg Ringer +2
    • Philipp Gampe +1

Issues 1

Files 1

Review log 11

  1. Xavier Perseguers commented on patch set 2 09/14/11, 08:21

    Could you have a look at new EM as well?
  2. Xavier Perseguers commented on patch set 2 09/14/11, 08:21

    It's up to you. The commit message and bug description is general enough to encompass both fixes if you wish but if you prefer you may open a new one as well.
  3. Helmut Hummel commented on patch set 2 09/14/11, 08:21

    Yes, I will do, but that is probably a bit more complex. Should I do that in this patch request, or should we open a different one?
  4. Helmut Hummel uploaded patch set 2 09/14/11, 08:21

  5. Philipp Gampe commented on patch set 2 09/14/11, 08:21

    Fails Does not work for me if updating from (new) em directly. If using the submodule update extensions, it works.
  6. Philipp Gampe commented on patch set 2 09/14/11, 08:21

    Verified; Looks good to me, but someone else must approve Maybe you should tell in the commit message, that this just effects the submodule.
  7. Philipp Gampe commented on patch set 2 09/14/11, 08:21

    No score
  8. Mr. Jenkins commented on patch set 1 09/14/11, 08:21

  9. Mr. Jenkins commented on patch set 2 09/14/11, 08:21

  10. Georg Ringer commented on patch set 2 V 0 09/14/11, 08:21

    by team member; Looks good to me, approved
  11. Georg Ringer merged patch set 2 09/14/11, 08:21