Review main Abandoned

49041[WIP][FEATURE] Enable random sorting in Extbase

Marc Horst CR 0 V 0 Easy +19 −10 updated 07/27/16, 09:22

Commit message

With this commit it is possible to sort querys randomly.
But I think we have to find an solution for multiple dbms.

Also caching have to be disabled for this query if random is used.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 34

  1. Marc Horst uploaded patch set 1 07/19/16, 05:36

  2. TYPO3com voted on patch set 1 V -1 07/19/16, 05:46 Completed build in 09m 44s on Tue, 19 Jul, 07:46 AM Test Summary: 2 of 19296 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1058

  3. Wouter Wolters commented on patch set 1 CR -1 07/22/16, 06:38

    ORDER BY RAND() is basically database suicide: don't do it, since it has a complexity of O(rand()) or greater, which can be quite problematic.
  4. Wouter Wolters abandoned the change 07/27/16, 09:22

    I reject this feature as this is not supported by doctrine and will not be supported by doctrine. As we switch the core database layer to doctrine this won't make it.