4906[BUGFIX] Install tool stays open if ENABLE_INSTALL_TOOL is not writable
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Markus Klein +1
-
Verified V +2
- Christian Kuhn +2
- Markus Klein +1
Files 1
Review log 29
Show 4 earlier messages
-
Björn Pedersen commented on patch set 1 10/26/11, 22:13
Looks good to me, but someone else must approve Looks OK to me. -
Markus Klein commented on patch set 1 10/26/11, 22:13
(3 inline comments)Please review the guidelines for the commit message format.Move the reference to the issue in forge down. see belowAdd the Lines: Relates: #29674 Releases: 4.6, 4,5, <whatever this applies to> -
Markus Klein commented on patch set 1 10/26/11, 22:13
Just do a commit --amend and change the message. Important: keep the change-id line in the message. Then you can push it again and it will show up as a new patchset. -
Lucas Jenß commented on patch set 1 10/26/11, 22:13
Do I have to re-submit the change or can I somehow modify the already published one?
-
Björn Pedersen commented on patch set 2 10/26/11, 22:13
Looks good to me, but someone else must approve -
Dmitry Dulepov commented on patch set 2 10/26/11, 22:13
I would prefer that you didn't submit this This change causes a minor annoyance :) On my local development computer I force ENABLE_INSTALL_TOOL to be non-removable. This is a developer's workstation, so I want to have that file all the time and there is no risk. So I lock it for modification using file system locking. I do not want to modify core ("1==1") to make Install tool work because this may cause accidental wrong commit. There can be other reasons to keep Install tool unlocked without mcore modification, for example, if TYPO3 is password-protected. But with this change we remove such possibility. In my opinion, the more freedom we give, the better. I would prefer to see a warning instead of silent forceful lock up of Install tool without any explanation. -
Dmitry Dulepov commented on patch set 2 10/26/11, 22:13
It is not my personal preference only. As I wrote, ENABLE_INSTALL_TOOL can be made permanent when typo3/ path is protected by other means. Your patch removes ability to make Install tool permanently open. You should give a warning because this is what admins should see. You mask the problem and do not provide admins the way to see and solve it. This is a wrong approach. Go for more flexibility and better error reporting, not for enforcing. -
Markus Klein commented on patch set 2 10/26/11, 22:13
Fails; I would prefer that you didn't submit this The check for is_writeable() is wrong! The file doesn't need to be writable at all in order to get successfully deleted/unlinked. The necessary and sufficient condition is to have write permissions on the typo3conf directory. -
Markus Klein commented on patch set 2 10/26/11, 22:13
Is there actually a documentation about this? A quick google search didn't reveal anything. -
Markus Klein commented on patch set 2 10/26/11, 22:13
Sure! My search results only show forums, blogs, lists and so on. But not a single link to an official documentation. i.e. typo3.org or the Wiki -
Markus Klein commented on patch set 2 10/26/11, 22:13
Looks good to me, but someone else must approve Please change also your name in your local GIT settings, so that the Owner field above also contains your full name. Thanks. -
Markus Klein commented on patch set 3 10/26/11, 22:13
So now: * No warnings * Deletes file whenever possible * Implements Lucas' idea -
Markus Klein uploaded patch set 3 10/26/11, 22:13
-
Markus Klein uploaded patch set 4 10/26/11, 22:13
-
Markus Klein commented on patch set 5 10/26/11, 22:13
Verified; Looks good to me, but someone else must approve -
Christian Kuhn uploaded patch set 5 10/26/11, 22:13
-
Christian Kuhn commented on patch set 5 V 0 10/26/11, 22:13
by team member; Looks good to me, approved -
Christian Kuhn commented on patch set 5 10/26/11, 22:13
Verified; Looks good to me, but someone else must approve Renamed the variable and made the commit comment shorter and more descriptive -
Steffen Gebert commented on patch set 2 10/26/11, 22:13
Dmity, you can put KEEP_FILE into ENABLE_INSTALL_TOOL and the file won't be deleted ;-) -
Steffen Gebert commented on patch set 2 10/26/11, 22:13
-
Steffen Gebert commented on patch set 2 10/26/11, 22:13
AFAIK that's only true for *nix systems... -
Lucas Jenß uploaded patch set 2 10/26/11, 22:13
-
Lucas Jenß commented on patch set 2 10/26/11, 22:13
@Dmitry Dulepov: While I understand that you'd like the mechanism to stay the way it is, because it is more convenient for you on your workstation, I have to argue that personal convenience should not be a reason to leave a possible security problem unpatched. The reason you don't want to modify the core ("1==1") (which is the intended mechanism to always enable the install tool, if you can believe the comment), is also debatable as you can easily ignore the file using "git update-index --assume-unchanged". While I do not agree with you, I will of course change my patch to display a warning message instead if that is what the majority desires. -
Mr. Jenkins commented on patch set 1 10/26/11, 22:13
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1831/ : SUCCESS -
Mr. Jenkins commented on patch set 2 10/26/11, 22:13
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1834/ : SUCCESS -
Mr. Jenkins commented on patch set 3 10/26/11, 22:13
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2173/ : SUCCESS -
Mr. Jenkins commented on patch set 4 10/26/11, 22:13
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2324/ : SUCCESS -
Mr. Jenkins commented on patch set 5 10/26/11, 22:13
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2329/ : SUCCESS -
Christian Kuhn merged patch set 5 10/26/11, 22:13