Review main Merged

49089[FOLLOWUP][TASK] Move arguments to initializeArguments() in HtmlVH in ext:fluid

Johannes Goslar CR +2 V +2 Easy +2 −8 updated 07/19/16, 12:03

Commit message

This patch adds the missing parent::initializeArguments() call.

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Steven Cardoso +1
    • Arthur Rehm +1
    • Markus Friedrich +1
  • Verified V +2
    • Nicole Hummel +2
    • Steven Cardoso +1
    • Arthur Rehm +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Johannes Goslar uploaded patch set 1 07/19/16, 11:24

  2. Johannes Goslar uploaded patch set 2 07/19/16, 11:29

  3. Gleb Levitin commented on patch set 1 CR +1 V +1 07/19/16, 11:34

    Verified by unit testing.
  4. TYPO3com voted on patch set 1 V +1 07/19/16, 11:35 Completed build in 10m 45s on Tue, 19 Jul, 01:35 PM Test Summary: 19310 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1101

  5. Nicole Hummel voted on patch set 2 CR +1 V +1 07/19/16, 11:38

  6. TYPO3com voted on patch set 2 V +1 07/19/16, 11:42 Completed build in 09m 29s on Tue, 19 Jul, 01:42 PM Test Summary: 19312 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1103

  7. Arthur Rehm voted on patch set 2 CR +1 V +1 07/19/16, 12:00

  8. Markus Friedrich voted on patch set 2 CR +1 07/19/16, 12:02

  9. Steven Cardoso voted on patch set 2 CR +1 V +1 07/19/16, 12:02

  10. Nicole Hummel voted on patch set 2 CR +2 V +2 07/19/16, 12:03

  11. Gerrit merged patch set 2 07/19/16, 12:03