Review main Merged

49117[BUGFIX] Allow overriding of image manipulation crop ratios

Benni Mack CR +2 V +2 Easy +1 −0 updated 07/20/16, 06:59

Commit message

It is not possible to change or override crop ratios via TSconfig
for sys_file_reference (e.g. for a specific user or page tree branch),
thus making the cropping functionality a pain for bigger sites.

Setting a FormEngine option as expected like
  TCEFORM.sys_file_reference.crop.config.ratios.2\.15 = Widescreen
does now work.

Review

  • Code review CR +2
    • Benni Mack +2
    • Georg Ringer +1
    • Wouter Wolters +1
  • Verified V +2
    • Benni Mack +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Benni Mack uploaded patch set 1 07/19/16, 20:38

  2. TYPO3com voted on patch set 1 V +1 07/19/16, 20:43 Completed build in 04m 33s on Tue, 19 Jul, 10:43 PM Test Summary: 19312 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1155

  3. Wouter Wolters commented on patch set 1 07/19/16, 21:09

    this does not belong in the commit message.
  4. Benni Mack updated the commit message in patch set 2 07/19/16, 23:05

  5. TYPO3com voted on patch set 2 V +1 07/19/16, 23:11 Completed build in 05m 16s on Wed, 20 Jul, 01:11 AM Test Summary: 19312 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1157

  6. Wouter Wolters voted on patch set 2 CR +1 V +1 07/20/16, 06:28

  7. Georg Ringer voted on patch set 2 CR +1 V +1 07/20/16, 06:51

  8. Benni Mack voted on patch set 2 CR +2 V +2 07/20/16, 06:58

  9. Gerrit merged patch set 2 07/20/16, 06:58

  10. Benni Mack commented on patch set 3 07/20/16, 06:59

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 327844753af0a352bd7e1c26f0a5b745349dcf70