Review main Abandoned

49130[TASK] Update moment.js and moment-timezone.js to newest version

Wouter Wolters CR 0 V 0 Hard +673 −76 updated 07/26/16, 07:54

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 56

  1. Wouter Wolters uploaded patch set 1 07/20/16, 12:27

  2. TYPO3com voted on patch set 1 V +1 07/20/16, 12:31 Completed build in 04m 04s on Wed, 20 Jul, 02:31 PM Test Summary: 19320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1192

  3. Markus Klein commented on patch set 1 CR +1 07/23/16, 08:50

    not sure why the localization lines are missing now in the moment.js file
  4. Andreas Kienast commented on patch set 1 07/23/16, 10:20

    I guess we need moment-with-locales.js, the labels previously used in moment.js are placed in there now.
  5. Wouter Wolters commented on patch set 1 CR -1 07/23/16, 10:23

    Hold on here, this is not correct.
  6. Wouter Wolters abandoned the change 07/26/16, 07:54

    this needs a bigger refactoring if we want locales to work again.