Review main Merged Breaking

49135[!!!][TASK] Remove various TSFE properties

Benni Mack CR +2 V +2 Hard +135 −124 updated 07/31/16, 11:48

Commit message

The short-hand syntax for TYPO3_CONF_VARS in TSFE
is rather tedious when explaining to newcomers why
it was solved this way 12 years ago.

The patch changes all occurrences to use the
global array, as in all other parts of the TYPO3 Core.

Additionally, the following public properties are removed:

* defaultBodyTag (can be overriden via TypoScript)
* clientInfo (can be loaded via GeneralUtility::clientInfo())

Review

  • Code review CR +2
    • Benni Mack +2
    • Oliver Klee +1
    • Markus Klein +1
  • Verified V +2
    • Benni Mack +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1520

  1. Benni Mack uploaded patch set 1 07/20/16, 15:12

  2. TYPO3com voted on patch set 1 V +1 07/20/16, 15:16 Completed build in 04m 19s on Wed, 20 Jul, 05:16 PM Test Summary: 19320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1196

  3. Benni Mack uploaded patch set 2 07/20/16, 22:30

  4. TYPO3com voted on patch set 2 V +1 07/20/16, 22:35 Completed build in 04m 35s on Thu, 21 Jul, 12:35 AM Test Summary: 19320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1216

  5. Benni Mack uploaded patch set 3 07/20/16, 22:35

  6. TYPO3com voted on patch set 3 V +1 07/20/16, 22:40 Completed build in 04m 33s on Thu, 21 Jul, 12:40 AM Test Summary: 19320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1217

  7. Markus Klein commented on patch set 3 CR -1 07/20/16, 23:38

    TypoScriptFrontendController.php:685

    This is necessary for any extension that wants to modify the page title. And this is the ONLY correct way to do so! See ext:news.
  8. Benni Mack uploaded patch set 4 07/28/16, 16:41

  9. TYPO3com voted on patch set 4 V +1 07/28/16, 16:46 Completed build in 04m 59s on Thu, 28 Jul, 06:46 PM Test Summary: 19378 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1452

  10. Georg Ringer voted on patch set 4 CR +1 V +1 07/29/16, 10:38

  11. Markus Klein commented on patch set 4 CR -1 07/29/16, 11:44

    TypoScriptFrontendController.php:852

    where should this be set?
  12. Oliver Klee voted on patch set 4 CR +1 07/29/16, 12:10

  13. Andreas Kienast commented on patch set 4 07/29/16, 12:14

    TypoScriptFrontendController.php:852 Reply

    The whole line looks like a left-over, as the property is removed.
  14. Andreas Kienast voted on patch set 4 CR -1 07/29/16, 12:14

  15. Andreas Kienast commented on patch set 5 07/29/16, 12:44

    Published edit on patch set 4.
  16. Oliver Klee voted on patch set 5 CR +1 07/29/16, 12:53

  17. TYPO3com voted on patch set 5 V +1 07/29/16, 12:55 Completed build in 09m 09s on Fri, 29 Jul, 02:55 PM Test Summary: 19378 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1496

  18. Markus Klein voted on patch set 5 CR +1 V +1 07/30/16, 00:18

  19. Benni Mack voted on patch set 5 CR +2 V +2 07/31/16, 11:48

  20. Gerrit merged patch set 5 07/31/16, 11:48