49135[!!!][TASK] Remove various TSFE properties
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Oliver Klee +1
- Markus Klein +1
-
Verified V +2
- Benni Mack +2
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 7
- typo3/sysext/core/Documentation/Changelog/master/Breaking-77184-VariousTSFEPropertiesRemoved.rstnew+38 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php3+88 −110
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+2 −2
- typo3/sysext/frontend/Classes/Page/PageGenerator.php+1 −5
- typo3/sysext/frontend/Classes/Utility/EidUtility.php+1 −1
- typo3/sysext/frontend/Tests/Unit/Controller/TypoScriptFrontendControllerTest.php+1 −2
- typo3/sysext/version/Classes/Hook/PreviewHook.php+4 −4
Review log 1520
-
Benni Mack uploaded patch set 1 07/20/16, 15:12
-
TYPO3com voted on patch set 1 V +1 07/20/16, 15:16 Completed build in 04m 19s on Wed, 20 Jul, 05:16 PM Test Summary: 19320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1196
-
Benni Mack uploaded patch set 2 07/20/16, 22:30
-
TYPO3com voted on patch set 2 V +1 07/20/16, 22:35 Completed build in 04m 35s on Thu, 21 Jul, 12:35 AM Test Summary: 19320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1216
-
Benni Mack uploaded patch set 3 07/20/16, 22:35
-
TYPO3com voted on patch set 3 V +1 07/20/16, 22:40 Completed build in 04m 33s on Thu, 21 Jul, 12:40 AM Test Summary: 19320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1217
-
Markus Klein commented on patch set 3 CR -1 07/20/16, 23:38
-
Benni Mack uploaded patch set 4 07/28/16, 16:41
-
TYPO3com voted on patch set 4 V +1 07/28/16, 16:46 Completed build in 04m 59s on Thu, 28 Jul, 06:46 PM Test Summary: 19378 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1452
-
Georg Ringer voted on patch set 4 CR +1 V +1 07/29/16, 10:38
-
Markus Klein commented on patch set 4 CR -1 07/29/16, 11:44
TypoScriptFrontendController.php:852where should this be set? -
Oliver Klee voted on patch set 4 CR +1 07/29/16, 12:10
-
Andreas Kienast commented on patch set 4 07/29/16, 12:14
TypoScriptFrontendController.php:852ReplyThe whole line looks like a left-over, as the property is removed. -
Andreas Kienast voted on patch set 4 CR -1 07/29/16, 12:14
-
Andreas Kienast commented on patch set 5 07/29/16, 12:44
Published edit on patch set 4. -
Oliver Klee voted on patch set 5 CR +1 07/29/16, 12:53
-
TYPO3com voted on patch set 5 V +1 07/29/16, 12:55 Completed build in 09m 09s on Fri, 29 Jul, 02:55 PM Test Summary: 19378 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1496
-
Markus Klein voted on patch set 5 CR +1 V +1 07/30/16, 00:18
-
Benni Mack voted on patch set 5 CR +2 V +2 07/31/16, 11:48
-
Gerrit merged patch set 5 07/31/16, 11:48
TypoScriptFrontendController.php:685