49140[TASK] Remove siteRelPath from TYPO3_LOADED_EXT
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Sascha Egerer +1
- Christian Kuhn +1
-
Verified V +2
- Andreas Kienast +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/about/Classes/Domain/Repository/ExtensionRepository.php+2 −1
- typo3/sysext/core/Classes/Compatibility/LoadedExtensionArrayElement.php1+1 −2
- typo3/sysext/documentation/Classes/Domain/Repository/DocumentRepository.php1+26 −17
- typo3/sysext/documentation/Classes/Service/DocumentationService.php1+16 −11
Review log 1315
-
Benni Mack uploaded patch set 1 07/20/16, 22:12
-
TYPO3com voted on patch set 1 V +1 07/20/16, 22:19 Completed build in 05m 46s on Thu, 21 Jul, 12:19 AM Test Summary: 19320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1215
-
Wouter Wolters voted on patch set 1 CR +1 V +1 07/21/16, 07:19
-
Sascha Egerer commented on patch set 1 CR -1 07/21/16, 20:04
-
Sascha Egerer commented on patch set 1 07/21/16, 20:06
DocumentationService.php:71Add a use statement for this class -
Ivan Dharma Kartolo uploaded patch set 2 07/22/16, 13:15
-
Ivan Dharma Kartolo commented on patch set 2 07/22/16, 13:16
Applied Sascha's comments. -
TYPO3com voted on patch set 2 V +1 07/22/16, 13:22 Completed build in 05m 34s on Fri, 22 Jul, 03:22 PM Test Summary: 19358 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1295
-
Sascha Egerer voted on patch set 2 CR +1 07/22/16, 18:11
-
Christian Kuhn commented on patch set 2 CR -1 07/22/16, 21:43
asking benni for a detail on this. -
Christian Kuhn commented on patch set 2 CR +1 07/22/16, 21:49
LoadedExtensionArrayElement.php:92note from benni: this detail is actually a breaking change - but that change is part of a bigger change of typo3_loaded_ext and a final breaking .rst file will follow wthen the stuff is finished. -
Christian Kuhn voted on patch set 2 V +1 07/22/16, 21:49
-
Andreas Kienast commented on patch set 2 CR -1 07/23/16, 10:30
-1 for the time being Searching for `'siteRelPath'` in PhpStorm reveals some more occurrences, are those correct or do they need adaption as well? -
Andreas Kienast voted on patch set 2 CR +2 V +2 07/23/16, 15:25
-
Gerrit merged patch set 2 07/23/16, 15:25
DocumentRepository.php:218