49150[BUGFIX] RTE: Correct behavior on empty textfield in Firefox
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Wouter Wolters +1
-
Verified V +2
- Jigal van Hemert +2
- Wouter Wolters +1
- Riccardo De Contardi +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/rtehtmlarea/Resources/Public/JavaScript/HTMLArea/DOM/DOM.js+2 −2
- typo3/sysext/rtehtmlarea/Resources/Public/JavaScript/HTMLArea/DOM/Selection.js+37 −36
- typo3/sysext/rtehtmlarea/Resources/Public/JavaScript/Plugins/BlockElements.js+8 −8
- typo3/sysext/rtehtmlarea/Resources/Public/JavaScript/Plugins/DefinitionList.js+1 −1
- typo3/sysext/rtehtmlarea/Resources/Public/JavaScript/Plugins/MicrodataSchema.js+1 −1
Review log 1926
Show 1 earlier messages
-
Andreas Kienast uploaded patch set 1 07/21/16, 12:14
-
Andreas Kienast updated the commit message in patch set 2 07/21/16, 12:15
-
TYPO3com voted on patch set 1 V +1 07/21/16, 12:19 Completed build in 04m 38s on Thu, 21 Jul, 02:19 PM Test Summary: 19328 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1244
-
TYPO3com voted on patch set 2 V +1 07/21/16, 12:29 Completed build in 12m 46s on Thu, 21 Jul, 02:29 PM Test Summary: 19328 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1245
-
Andreas Kienast commented on patch set 2 CR -1 07/22/16, 06:44
CR-1 for the time being, it seems there is a regression that disturbs multiple compontents of the RTE. -
Andreas Kienast uploaded patch set 3 07/23/16, 09:37
-
Andreas Kienast updated the commit message in patch set 4 07/23/16, 09:40
-
TYPO3com voted on patch set 3 V +1 07/23/16, 09:43 Completed build in 06m 12s on Sat, 23 Jul, 11:43 AM Test Summary: 19358 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1322
-
TYPO3com voted on patch set 4 V +1 07/23/16, 09:47 Completed build in 06m 26s on Sat, 23 Jul, 11:47 AM Test Summary: 19358 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1323
-
Markus Klein updated the commit message in patch set 5 07/23/16, 11:44
-
Markus Klein commented on patch set 5 07/23/16, 11:45
is this also an issue on 7.6? -
Andreas Kienast commented on patch set 5 07/23/16, 11:51
Reply
Yes, I'll update the commit message -
Andreas Kienast updated the commit message in patch set 6 07/23/16, 11:51
-
TYPO3com voted on patch set 5 V -1 07/23/16, 11:55 Completed build in 10m 37s on Sat, 23 Jul, 01:55 PM Test Summary: 18737 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1328
-
TYPO3com voted on patch set 6 V +1 07/23/16, 12:00 Completed build in 08m 41s on Sat, 23 Jul, 02:00 PM Test Summary: 19358 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1329
-
Frederic Gaus voted on patch set 6 CR +1 07/25/16, 12:58
-
Wouter Wolters rebased onto patch set 7 07/26/16, 12:00
-
Wouter Wolters voted on patch set 7 CR +1 V +1 07/26/16, 12:03
-
Wouter Wolters wrote 07/26/16, 12:03
Topic doctrine removed -
TYPO3com voted on patch set 7 V +1 07/26/16, 12:05 Completed build in 04m 46s on Tue, 26 Jul, 02:05 PM Test Summary: 19372 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1378
-
Riccardo De Contardi commented on patch set 7 V -1 07/26/16, 14:15
it does not seem to work for me (tested on Master, latest FF) - steps: 1) install patch, delete typo3temp, clear cache from install tool. 2) create text/w media CE 3) type something in bodytext, hit enter, type something 4) save 5) cmd+a (select all); backspace result: the error is still present -
Wouter Wolters commented on patch set 7 07/26/16, 14:18
Please make sure to clear browser caches. Swith to private mode for example to test the patch. -
Riccardo De Contardi commented on patch set 7 V +1 07/26/16, 14:25
nice catch, Wouter! I remove my -1 and vote +1 as the patch seems to work. -
Jigal van Hemert voted on patch set 7 CR +2 V +2 07/26/16, 14:35
-
Gerrit merged patch set 7 07/26/16, 14:35
-
Jigal van Hemert commented on patch set 8 07/26/16, 14:39
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit c4d1364573c3517247e70a32d248e779b4f3f81a