49169[TASK] Use new instead of makeInstance in unit tests
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Ivan Dharma Kartolo +1
-
Verified V +2
- Christian Kuhn +2
- Ivan Dharma Kartolo +1
- TYPO3com +1 CI
Issues 1
Files 6
- typo3/sysext/install/Tests/Unit/Service/SqlSchemaMigrationServiceTest.php+4 −2
- typo3/sysext/saltedpasswords/Tests/Unit/Salt/BlowfishSaltTest.php+1 −2
- typo3/sysext/saltedpasswords/Tests/Unit/Salt/Md5SaltTest.php+1 −2
- typo3/sysext/saltedpasswords/Tests/Unit/Salt/Pbkdf2SaltTest.php+1 −2
- typo3/sysext/saltedpasswords/Tests/Unit/Salt/PhpassSaltTest.php+1 −2
- typo3/sysext/saltedpasswords/Tests/Unit/Salt/SaltFactoryTest.php+2 −3
Review log 812
-
Minh Thien Nhan uploaded patch set 1 07/22/16, 12:21
-
TYPO3com voted on patch set 1 V -1 07/22/16, 12:29 Completed build in 05m 18s on Fri, 22 Jul, 02:29 PM Test Summary: 19358 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1285
-
Minh Thien Nhan uploaded patch set 2 07/22/16, 13:07
-
Christian Kuhn updated the commit message in patch set 3 07/22/16, 13:10
-
Christian Kuhn uploaded patch set 4 07/22/16, 13:15
-
TYPO3com voted on patch set 3 V +1 07/22/16, 13:17 Completed build in 05m 24s on Fri, 22 Jul, 03:17 PM Test Summary: 19358 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1293
-
Christian Kuhn commented on patch set 4 CR +1 V +1 07/22/16, 13:18
looks good to me. -
Ivan Dharma Kartolo voted on patch set 4 CR +1 V +1 07/22/16, 13:19
-
TYPO3com voted on patch set 4 V +1 07/22/16, 13:20 Completed build in 05m 04s on Fri, 22 Jul, 03:20 PM Test Summary: 19358 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1294
-
Christian Kuhn voted on patch set 4 CR +2 V +2 07/22/16, 13:25
-
Gerrit merged patch set 4 07/22/16, 13:25
-
TYPO3com commented on patch set 2 07/22/16, 21:29 Completed build in 8h 26m 35s on Fri, 22 Jul, 11:29 PM Test Summary: 19358 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1291