Review main Merged

49169[TASK] Use new instead of makeInstance in unit tests

Minh Thien Nhan CR +2 V +2 Easy +10 −13 updated 07/22/16, 21:29

Commit message

Instantiating test subject in unit tests with makeInstance()
is not a good thing since this may trigger xclass and
singleton patterns. This is not wanted. Use new() instead.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Ivan Dharma Kartolo +1
  • Verified V +2
    • Christian Kuhn +2
    • Ivan Dharma Kartolo +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 812

  1. Minh Thien Nhan uploaded patch set 1 07/22/16, 12:21

  2. TYPO3com voted on patch set 1 V -1 07/22/16, 12:29 Completed build in 05m 18s on Fri, 22 Jul, 02:29 PM Test Summary: 19358 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1285

  3. Minh Thien Nhan uploaded patch set 2 07/22/16, 13:07

  4. Christian Kuhn updated the commit message in patch set 3 07/22/16, 13:10

  5. Christian Kuhn uploaded patch set 4 07/22/16, 13:15

  6. TYPO3com voted on patch set 3 V +1 07/22/16, 13:17 Completed build in 05m 24s on Fri, 22 Jul, 03:17 PM Test Summary: 19358 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1293

  7. Christian Kuhn commented on patch set 4 CR +1 V +1 07/22/16, 13:18

    looks good to me.
  8. Ivan Dharma Kartolo voted on patch set 4 CR +1 V +1 07/22/16, 13:19

  9. TYPO3com voted on patch set 4 V +1 07/22/16, 13:20 Completed build in 05m 04s on Fri, 22 Jul, 03:20 PM Test Summary: 19358 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1294

  10. Christian Kuhn voted on patch set 4 CR +2 V +2 07/22/16, 13:25

  11. Gerrit merged patch set 4 07/22/16, 13:25

  12. TYPO3com commented on patch set 2 07/22/16, 21:29 Completed build in 8h 26m 35s on Fri, 22 Jul, 11:29 PM Test Summary: 19358 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1291