49182[FEATURE] Integrate Swift Mailer's spool transport
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Mathias Schreiber +1
-
Verified V +2
- Benni Mack +2
- Mathias Schreiber +1
- TYPO3com +1 CI
Issues 1
Files 15
- typo3/sysext/core/Classes/Command/SendEmailCommand.php1new+79 −0
- typo3/sysext/core/Classes/Mail/Mailer.php4+23 −53
- typo3/sysext/core/Classes/Mail/MemorySpool.php2new+59 −0
- typo3/sysext/core/Classes/Mail/TransportFactory.php10new+134 −0
- typo3/sysext/core/Configuration/Commands.phpnew+7 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+2 −0
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml+6 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-76349-IntegrateSwiftMailersSpoolTransportIntoTYPO3.rstnew+67 −0
- typo3/sysext/core/Tests/Unit/Command/SendEmailCommandTest.phpnew+71 −0
- typo3/sysext/core/Tests/Unit/Mail/Fixtures/FakeFileSpoolFixture.phpnew+31 −0
- typo3/sysext/core/Tests/Unit/Mail/Fixtures/FakeInvalidSpoolFixture.phpnew+53 −0
- typo3/sysext/core/Tests/Unit/Mail/Fixtures/FakeMemorySpoolFixture.phpnew+28 −0
- typo3/sysext/core/Tests/Unit/Mail/Fixtures/FakeValidSpoolFixture.phpnew+53 −0
- typo3/sysext/core/Tests/Unit/Mail/MailerTest.php1+33 −0
- typo3/sysext/core/Tests/Unit/Mail/TransportFactoryTest.phpnew+171 −0
Review log 1826
Show 1 earlier messages
-
Remo H. uploaded patch set 1 07/24/16, 19:36
-
TYPO3com voted on patch set 1 V -1 07/24/16, 19:40 Completed build in 03m 59s on Sun, 24 Jul, 09:40 PM Test Summary: 19374 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1341
-
Benni Mack commented on patch set 1 CR -1 04/21/17, 13:56
Are you going to upgrade your patch? Also, please provide Unit Tests and use the Symfony Command instead of Extbase Command Controller. -
Oliver Klee commented on patch set 1 04/21/17, 14:53
MessageSender.php:2Can we please have strict types for this file and return types for the methods?TransportFactory.php:3Can we please have strict types for this file and return types for the methods? -
Oliver Klee commented on patch set 1 04/21/17, 14:54
Mailer.php:111Can we please have return types for the new methods? -
Remo H. uploaded patch set 2 07/17/17, 16:51
-
TYPO3com voted on patch set 2 V -1 07/17/17, 16:51 Completed build in 08s on Mon, 17 Jul, 06:51 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13304
-
Remo H. uploaded patch set 3 07/17/17, 18:43
-
TYPO3com voted on patch set 3 V -1 07/17/17, 18:43 Completed build in 09s on Mon, 17 Jul, 08:43 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13307
-
Remo H. uploaded patch set 4 07/17/17, 18:48
-
TYPO3com voted on patch set 4 V +1 07/17/17, 18:58 Completed build in 10m 23s on Mon, 17 Jul, 08:58 PM Test Summary: 56925 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13308
-
Benni Mack commented on patch set 4 07/18/17, 04:53
ext_localconf.php:91I think we can get rid of this one here now ;) -
Remo H. uploaded patch set 5 07/18/17, 16:12
-
TYPO3com voted on patch set 5 V +1 07/18/17, 16:22 Completed build in 10m 09s on Tue, 18 Jul, 06:22 PM Test Summary: 56925 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13317
-
Mathias Schreiber uploaded patch set 6 02/06/18, 19:39
-
TYPO3com voted on patch set 6 V +1 02/06/18, 19:45 Completed build in 05m 36s on Tue, 6 Feb, 08:45 PM Test Summary: 30464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19032
-
Benni Mack uploaded patch set 7 02/07/18, 21:16
-
TYPO3com voted on patch set 7 V +1 02/07/18, 21:22 Completed build in 06m 07s on Wed, 7 Feb, 10:22 PM Test Summary: 30485 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19109
-
Mathias Schreiber uploaded patch set 8 02/10/18, 23:29
-
Mathias Schreiber voted on patch set 8 V +1 CR +1 02/10/18, 23:31
-
TYPO3com voted on patch set 8 V +1 02/10/18, 23:38 Completed build in 09m 15s on Sun, 11 Feb, 12:38 AM Test Summary: 30506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19327
-
Benni Mack voted on patch set 8 V +2 CR +2 02/10/18, 23:44
-
Benni Mack merged patch set 9 02/10/18, 23:44
-
Markus Klein commented on patch set 9 02/13/18, 21:29
post -1SendEmailCommand.php:2strict missingMailer.php:106are we using that?Mailer.php:110CGLMailer.php:110we have a lovely operator for that called: !MemorySpool.php:2strict types missingTransportFactory.php:2strict types missingTransportFactory.php:31CGLTransportFactory.php:46CGLTransportFactory.php:56We always use $GLOBALS now, not this old formTransportFactory.php:59string?TransportFactory.php:77We always use $GLOBALS now, not this old formTransportFactory.php:85We always use $GLOBALS now, not this old formTransportFactory.php:88why using FQN? should be shortened anyways. (that's even in the same namespace!)TransportFactory.php:126not necessaryMailerTest.php:139should have been removed before merge -
Markus Klein commented on patch set 9 02/13/18, 21:37
patch with fixes is handled via https://forge.typo3.org/issues/83880 -
Oliver Hader commented on patch set 9 02/14/18, 09:46
MemorySpool.php:37Creating new instances in a destructor might have some side-effects...