Review main Merged

49182[FEATURE] Integrate Swift Mailer's spool transport

Remo H. CR +2 V +2 Hard +817 −53 updated 02/14/18, 09:46

Commit message

Adds new configuration to the install tool and provides an
extbase schedular task and command.

A small refactoring was required:
* Moved transport creation from mailer to a factory

Possible issues are:
* sending of memory-spooled messages is a bit hacky

Review

  • Code review CR +2
    • Benni Mack +2
    • Mathias Schreiber +1
  • Verified V +2
    • Benni Mack +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 15

Review log 1826

Show 1 earlier messages
  1. Remo H. uploaded patch set 1 07/24/16, 19:36

  1. TYPO3com voted on patch set 1 V -1 07/24/16, 19:40 Completed build in 03m 59s on Sun, 24 Jul, 09:40 PM Test Summary: 19374 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1341

  2. Benni Mack commented on patch set 1 CR -1 04/21/17, 13:56

    Are you going to upgrade your patch? Also, please provide Unit Tests and use the Symfony Command instead of Extbase Command Controller.
  3. Oliver Klee commented on patch set 1 04/21/17, 14:53

    MessageSender.php:2

    Can we please have strict types for this file and return types for the methods?

    TransportFactory.php:3

    Can we please have strict types for this file and return types for the methods?
  4. Oliver Klee commented on patch set 1 04/21/17, 14:54

    Mailer.php:111

    Can we please have return types for the new methods?
  5. Remo H. uploaded patch set 2 07/17/17, 16:51

  6. TYPO3com voted on patch set 2 V -1 07/17/17, 16:51 Completed build in 08s on Mon, 17 Jul, 06:51 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13304

  7. Remo H. uploaded patch set 3 07/17/17, 18:43

  8. TYPO3com voted on patch set 3 V -1 07/17/17, 18:43 Completed build in 09s on Mon, 17 Jul, 08:43 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13307

  9. Remo H. uploaded patch set 4 07/17/17, 18:48

  10. TYPO3com voted on patch set 4 V +1 07/17/17, 18:58 Completed build in 10m 23s on Mon, 17 Jul, 08:58 PM Test Summary: 56925 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13308

  11. Benni Mack commented on patch set 4 07/18/17, 04:53

    ext_localconf.php:91

    I think we can get rid of this one here now ;)
  12. Remo H. uploaded patch set 5 07/18/17, 16:12

  13. TYPO3com voted on patch set 5 V +1 07/18/17, 16:22 Completed build in 10m 09s on Tue, 18 Jul, 06:22 PM Test Summary: 56925 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13317

  14. Mathias Schreiber uploaded patch set 6 02/06/18, 19:39

  15. TYPO3com voted on patch set 6 V +1 02/06/18, 19:45 Completed build in 05m 36s on Tue, 6 Feb, 08:45 PM Test Summary: 30464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19032

  16. Benni Mack uploaded patch set 7 02/07/18, 21:16

  17. TYPO3com voted on patch set 7 V +1 02/07/18, 21:22 Completed build in 06m 07s on Wed, 7 Feb, 10:22 PM Test Summary: 30485 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19109

  18. Mathias Schreiber uploaded patch set 8 02/10/18, 23:29

  19. Mathias Schreiber voted on patch set 8 V +1 CR +1 02/10/18, 23:31

  20. TYPO3com voted on patch set 8 V +1 02/10/18, 23:38 Completed build in 09m 15s on Sun, 11 Feb, 12:38 AM Test Summary: 30506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19327

  21. Benni Mack voted on patch set 8 V +2 CR +2 02/10/18, 23:44

  22. Benni Mack merged patch set 9 02/10/18, 23:44

  23. Markus Klein commented on patch set 9 02/13/18, 21:29

    post -1

    SendEmailCommand.php:2

    strict missing

    Mailer.php:106

    are we using that?

    Mailer.php:110

    CGL

    Mailer.php:110

    we have a lovely operator for that called: !

    MemorySpool.php:2

    strict types missing

    TransportFactory.php:2

    strict types missing

    TransportFactory.php:31

    CGL

    TransportFactory.php:46

    CGL

    TransportFactory.php:56

    We always use $GLOBALS now, not this old form

    TransportFactory.php:59

    string?

    TransportFactory.php:77

    We always use $GLOBALS now, not this old form

    TransportFactory.php:85

    We always use $GLOBALS now, not this old form

    TransportFactory.php:88

    why using FQN? should be shortened anyways. (that's even in the same namespace!)

    TransportFactory.php:126

    not necessary

    MailerTest.php:139

    should have been removed before merge
  24. Markus Klein commented on patch set 9 02/13/18, 21:37

    patch with fixes is handled via https://forge.typo3.org/issues/83880
  25. Oliver Hader commented on patch set 9 02/14/18, 09:46

    MemorySpool.php:37

    Creating new instances in a destructor might have some side-effects...