Review TYPO3_7-6 Merged

49186[BUGFIX] indexed_search renders HTML5 placeholder regardless of sword

Daniel Neugebauer CR +2 V +2 Easy +9 −7 updated 10/06/16, 08:57

Commit message

If DocType is HTML5, placeholder attribute on sword input field is now
rendered regardless of sword being empty or not.

Review

  • Code review CR +2
    • Jan Helke +2
    • Dmitry Dulepov +1
  • Verified V +2
    • Jan Helke +2
    • Dmitry Dulepov +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Daniel Neugebauer uploaded patch set 1 07/25/16, 11:15

  2. Wouter Wolters commented on patch set 2 09/30/16, 09:49

    Published edit on patch set 1.
  3. Wouter Wolters voted on patch set 2 CR +1 09/30/16, 09:49

  4. TYPO3com voted on patch set 2 V +1 09/30/16, 09:52 Completed build in 02m 47s on Fri, 30 Sep, 11:52 AM Test Summary: 34918 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-137

  5. Dmitry Dulepov commented on patch set 2 09/30/16, 10:07

    SearchFormController.php:1370

    htmlspecialchars() here too? :)
  6. Wouter Wolters commented on patch set 3 09/30/16, 10:12

    Published edit on patch set 2.
  7. Dmitry Dulepov voted on patch set 3 CR +1 V +1 09/30/16, 10:13

  8. TYPO3com voted on patch set 3 V +1 09/30/16, 10:15 Completed build in 03m 03s on Fri, 30 Sep, 12:15 PM Test Summary: 34918 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-138

  9. Jan Helke voted on patch set 3 CR +1 V +1 10/06/16, 07:38

  10. Jan Helke voted on patch set 3 CR +2 V +2 10/06/16, 08:57

  11. Gerrit merged patch set 3 10/06/16, 08:57