Review main Abandoned

49187[TASK] Deprecate GeneralUtility::getUserObj()

Mathias Brodala CR 0 V 0 Normal +138 −109 updated 07/26/16, 07:23

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 55

Show 35 more files

Review log 1420

  1. Mathias Brodala uploaded patch set 1 07/25/16, 15:08

  2. Benni Mack commented on patch set 2 07/25/16, 15:10

    Published edit on patch set 1.
  3. Mathias Brodala uploaded patch set 3 07/25/16, 15:11

  4. Mathias Brodala commented on patch set 3 07/25/16, 15:12

    Added deprecation RST
  5. Mathias Brodala commented on patch set 3 07/25/16, 15:12

    > Patch Set 2: Published edit on patch set 1. Thanks. ;-)
  6. TYPO3com voted on patch set 1 V -1 07/25/16, 15:13 Completed build in 05m 23s on Mon, 25 Jul, 05:13 PM Test Summary: 19372 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1352

  7. TYPO3com voted on patch set 2 V -1 07/25/16, 15:14 Completed build in 04m 11s on Mon, 25 Jul, 05:14 PM Test Summary: 19372 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1353

  8. TYPO3com voted on patch set 3 V -1 07/25/16, 15:18 Completed build in 05m 42s on Mon, 25 Jul, 05:18 PM Test Summary: 19372 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1354

  9. Mathias Brodala uploaded patch set 4 07/25/16, 15:23

  10. Mathias Brodala commented on patch set 4 07/25/16, 15:23

    Fixed CGL errors.
  11. Andreas Kienast commented on patch set 3 07/25/16, 15:25

    GeneralUtility.php:3816

    TYPO3 v8

    GeneralUtility.php:3816

    TYPO3 v9
  12. TYPO3com voted on patch set 4 V +1 07/25/16, 15:28 Completed build in 05m 15s on Mon, 25 Jul, 05:28 PM Test Summary: 19372 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1355

  13. Mathias Brodala uploaded patch set 5 07/25/16, 15:29

  14. Mathias Brodala commented on patch set 5 07/25/16, 15:32

    Now with 200% more "v".
  15. Mathias Brodala commented on patch set 3 07/25/16, 15:33

    GeneralUtility.php:3816 Reply

    Done

    GeneralUtility.php:3816 Reply

    Done
  16. Mathias Brodala updated the commit message in patch set 6 07/25/16, 15:33

  17. TYPO3com voted on patch set 5 V +1 07/25/16, 15:35 Completed build in 05m 27s on Mon, 25 Jul, 05:35 PM Test Summary: 19372 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1356

  18. TYPO3com voted on patch set 6 V +1 07/25/16, 15:37 Completed build in 04m 14s on Mon, 25 Jul, 05:37 PM Test Summary: 19372 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1357

  19. Markus Klein commented on patch set 6 CR -1 V -1 07/25/16, 15:42

    This is actually breaking!! Consider TS that includes some PHP code using the old syntax with filename:class->func or the like. This will now break. Look into the code of getUserObj() please for the existing deprecation. We can NOT deprecate this function before CMS 9!!
  20. Mathias Brodala abandoned the change 07/26/16, 07:23

    Abandoned after further discussion. Since the file prefix was just deprecated with 8.2.0, we cannot deprecate the whole method just yet. This'll have to wait until v9 indeed.