49187[TASK] Deprecate GeneralUtility::getUserObj()
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 2
Files 55
- typo3/sysext/about/Classes/Controller/ModulesController.php+1 −1
- typo3/sysext/backend/Classes/Backend/ToolbarItems/ClearCacheToolbarItem.php+1 −1
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php+2 −2
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php+1 −1
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php+2 −2
- typo3/sysext/backend/Classes/Form/Element/AbstractFormElement.php+1 −1
- typo3/sysext/backend/Classes/Tree/Pagetree/DataProvider.php+1 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+3 −3
- typo3/sysext/backend/Classes/View/PageLayoutView.php+2 −2
- typo3/sysext/backend/Classes/FrontendBackendUserAuthentication.php+1 −1
- typo3/sysext/compatibility7/Classes/Controller/SearchFormController.php+3 −3
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+1 −1
- typo3/sysext/core/Classes/Controller/FileDumpController.php+1 −1
- typo3/sysext/core/Classes/Core/Bootstrap.php+1 −1
- typo3/sysext/core/Classes/Database/DatabaseConnection.php+1 −1
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+8 −8
- typo3/sysext/core/Classes/ExtDirect/ExtDirectApi.php+1 −1
- typo3/sysext/core/Classes/ExtDirect/ExtDirectRouter.php+1 −1
- typo3/sysext/core/Classes/FrontendEditing/FrontendEditingController.php+2 −2
- typo3/sysext/core/Classes/Html/RteHtmlParser.php+5 −5
Show 35 more files
- typo3/sysext/core/Classes/Imaging/IconFactory.php+1 −1
- typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php+2 −2
- typo3/sysext/core/Classes/Utility/GeneralUtility.php4+5 −2
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-77243-GeneralUtilitygetUserObjHasBeenDeprecated.rstnew+26 −0
- typo3/sysext/css_styled_content/Classes/Controller/CssStyledContentController.php+1 −1
- typo3/sysext/filelist/Classes/FileList.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentContentObject.php+2 −2
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+10 −10
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+4 −4
- typo3/sysext/frontend/Classes/Hooks/MediaItemHooks.php+2 −2
- typo3/sysext/frontend/Classes/Page/PageRepository.php+4 −4
- typo3/sysext/frontend/Classes/View/AdminPanelView.php+2 −2
- typo3/sysext/indexed_search/Classes/Controller/AdministrationController.php+1 −1
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+3 −3
- typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php+1 −1
- typo3/sysext/indexed_search/Classes/Hook/CrawlerHook.php+2 −2
- typo3/sysext/indexed_search/Classes/Indexer.php+3 −3
- typo3/sysext/linkvalidator/Classes/Report/LinkValidatorReport.php+1 −1
- typo3/sysext/linkvalidator/Classes/LinkAnalyzer.php+1 −1
- typo3/sysext/lowlevel/Classes/CleanerCommand.php+1 −1
- typo3/sysext/lowlevel/Classes/RteImagesCommand.php+1 −1
- typo3/sysext/recordlist/Classes/Controller/ElementBrowserController.php+1 −1
- typo3/sysext/recordlist/Classes/RecordList/AbstractDatabaseRecordList.php+2 −2
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+5 −5
- typo3/sysext/reports/Classes/Report/Status/SystemStatus.php+1 −1
- typo3/sysext/rsaauth/Classes/Backend/BackendFactory.php+1 −1
- typo3/sysext/rsaauth/Classes/Storage/StorageFactory.php+1 −1
- typo3/sysext/rtehtmlarea/Classes/Controller/ParseHtmlController.php+1 −1
- typo3/sysext/saltedpasswords/Classes/Salt/SaltFactory.php+3 −3
- typo3/sysext/saltedpasswords/Classes/Utility/ExtensionManagerConfigurationUtility.php+1 −1
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+5 −5
- typo3/sysext/sys_action/Classes/ActionTask.php+1 −1
- typo3/sysext/version/Classes/Hook/DataHandlerHook.php+1 −1
- typo3/sysext/workspaces/Classes/ExtDirect/ExtDirectServer.php+1 −1
Review log 1420
-
Mathias Brodala uploaded patch set 1 07/25/16, 15:08
-
Benni Mack commented on patch set 2 07/25/16, 15:10
Published edit on patch set 1. -
Mathias Brodala uploaded patch set 3 07/25/16, 15:11
-
Mathias Brodala commented on patch set 3 07/25/16, 15:12
Added deprecation RST -
Mathias Brodala commented on patch set 3 07/25/16, 15:12
> Patch Set 2: Published edit on patch set 1. Thanks. ;-) -
TYPO3com voted on patch set 1 V -1 07/25/16, 15:13 Completed build in 05m 23s on Mon, 25 Jul, 05:13 PM Test Summary: 19372 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1352
-
TYPO3com voted on patch set 2 V -1 07/25/16, 15:14 Completed build in 04m 11s on Mon, 25 Jul, 05:14 PM Test Summary: 19372 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1353
-
TYPO3com voted on patch set 3 V -1 07/25/16, 15:18 Completed build in 05m 42s on Mon, 25 Jul, 05:18 PM Test Summary: 19372 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1354
-
Mathias Brodala uploaded patch set 4 07/25/16, 15:23
-
Mathias Brodala commented on patch set 4 07/25/16, 15:23
Fixed CGL errors. -
Andreas Kienast commented on patch set 3 07/25/16, 15:25
GeneralUtility.php:3816TYPO3 v8GeneralUtility.php:3816TYPO3 v9 -
TYPO3com voted on patch set 4 V +1 07/25/16, 15:28 Completed build in 05m 15s on Mon, 25 Jul, 05:28 PM Test Summary: 19372 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1355
-
Mathias Brodala uploaded patch set 5 07/25/16, 15:29
-
Mathias Brodala commented on patch set 5 07/25/16, 15:32
Now with 200% more "v". -
Mathias Brodala commented on patch set 3 07/25/16, 15:33
GeneralUtility.php:3816ReplyDoneGeneralUtility.php:3816ReplyDone -
Mathias Brodala updated the commit message in patch set 6 07/25/16, 15:33
-
TYPO3com voted on patch set 5 V +1 07/25/16, 15:35 Completed build in 05m 27s on Mon, 25 Jul, 05:35 PM Test Summary: 19372 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1356
-
TYPO3com voted on patch set 6 V +1 07/25/16, 15:37 Completed build in 04m 14s on Mon, 25 Jul, 05:37 PM Test Summary: 19372 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1357
-
Markus Klein commented on patch set 6 CR -1 V -1 07/25/16, 15:42
This is actually breaking!! Consider TS that includes some PHP code using the old syntax with filename:class->func or the like. This will now break. Look into the code of getUserObj() please for the existing deprecation. We can NOT deprecate this function before CMS 9!! -
Mathias Brodala abandoned the change 07/26/16, 07:23
Abandoned after further discussion. Since the file prefix was just deprecated with 8.2.0, we cannot deprecate the whole method just yet. This'll have to wait until v9 indeed.