Review main Merged

49223[BUGFIX] Fixes the suggest wizard item click by only returning one value

Wiard van Rij CR +2 V +2 Easy +0 −1 updated 11/01/16, 13:38

Commit message

The bug only occurs on cases where the multiple true is defined,
and the user clicks on the element found by the suggest wizard.

This is caused because of a duplicate item insert. The onclick should
only prevent the default action, and not insert/return the item into the
list.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Benjamin Serfhos +1
    • Alexander Stehlik +1
  • Verified V +2
    • Frank Nägler +2
    • Benjamin Serfhos +1
    • Alexander Stehlik +1

Issues 1

Files 1

Review log 1314

  1. Wiard van Rij uploaded patch set 1 07/27/16, 07:12

  2. TYPO3com voted on patch set 1 V +1 07/27/16, 07:16 Completed build in 04m 39s on Wed, 27 Jul, 09:16 AM Test Summary: 19372 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1392

  3. Benjamin Serfhos voted on patch set 1 CR +1 V +1 07/27/16, 12:15

  4. Wiard van Rij uploaded patch set 2 09/02/16, 19:45

  5. Frank Nägler voted on patch set 2 CR +1 09/02/16, 19:58

  6. Frank Nägler voted on patch set 2 V +1 09/02/16, 19:58

  7. Daniel Goerz commented on patch set 2 09/02/16, 20:48

    Better describe what is now working instead of what was broken. e.g.: Prevent suggest wizard from suggesting a record twice
  8. Wiard van Rij updated the commit message in patch set 3 09/02/16, 21:12

  9. Alexander Stehlik commented on patch set 3 CR +1 V +1 09/02/16, 23:08

    Had some caching issues, but the new version fixes the problem, thank you :)
  10. Benjamin Serfhos voted on patch set 3 CR +1 V +1 09/03/16, 11:53

  11. Frank Nägler voted on patch set 3 CR +2 V +2 09/05/16, 07:23

  12. Gerrit merged patch set 3 09/05/16, 07:23

  13. Frank Nägler commented on patch set 4 09/05/16, 07:23

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit d5b463425af06f19787919d3404be72b65273a8d
  14. Christian Kuhn commented on patch set 4 11/01/16, 13:38

    this is in styleguide now with group_db_8