49224[BUGFIX] Do not override hidden UC fields in user settings
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Wouter Wolters +1
- Jörg Bösche +1
- Martin Fox +1
-
Verified V +2
- Markus Klein +2
- Wouter Wolters +1
- Martin Fox +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 4055
Show 2230 earlier messages
-
Stefan Froemken uploaded patch set 1 07/27/16, 07:38
-
Mathias Brodala updated the commit message in patch set 2 07/27/16, 07:39
-
TYPO3com voted on patch set 1 V +1 07/27/16, 07:43 Completed build in 04m 43s on Wed, 27 Jul, 09:43 AM Test Summary: 19372 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1395
-
TYPO3com voted on patch set 2 V +1 07/27/16, 07:44 Completed build in 03m 48s on Wed, 27 Jul, 09:44 AM Test Summary: 19372 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1396
-
Markus Klein voted on patch set 2 CR +1 07/27/16, 09:16
-
Christian Kuhn commented on patch set 2 07/27/16, 14:24
why is everything else a problem?what is the issue you're solving? -
Stefan Froemken updated the commit message in patch set 3 07/28/16, 07:11
-
TYPO3com voted on patch set 3 V +1 07/28/16, 07:19 Completed build in 08m 00s on Thu, 28 Jul, 09:19 AM Test Summary: 19378 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1420
-
Stefan Froemken commented on patch set 2 07/28/16, 07:28
Reply
Please have a look into the last 100 commit messages of core. "Updating bootstrap to 3.3.7". Is that a problem? No. It's something what has been done. "Set $escapeOutput to false". Is that a problem description? No. It's something what has be done and has nothing explained. "Remove own implementations in AbstractViewHelper". Is that a problem? TYPO3 is full of own implementations. So why are you kidding me, when I write what I have been done?Reply
Same here: https://review.typo3.org/#/c/49166/ no description. Or that one: https://review.typo3.org/#/c/49172/. That's a good one: Title and description have nothing to do each other. https://review.typo3.org/#/c/49146/ Something was removed and nobody knows why. https://review.typo3.org/#/c/48771/ no explaination why this is a good idea. What is the issue? Have a look into the forge ticket. -
Markus Klein commented on patch set 3 07/28/16, 08:13
To clarify things: commit msgs MUST NOT describe the problem, but describe WHAT IS CHANGED. -
Markus Klein updated the commit message in patch set 4 07/28/16, 08:14
-
Markus Klein voted on patch set 4 CR +1 07/28/16, 08:14
-
TYPO3com voted on patch set 4 V -1 07/28/16, 08:23 Completed build in 08m 24s on Thu, 28 Jul, 10:23 AM Test Summary: 19098 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1424
-
Stefan Froemken commented on patch set 4 07/28/16, 08:39
Thank you Markus for updating the commit message. -
TYPO3com voted on patch set 4 V +1 07/28/16, 09:22 Completed build in 1h 16m 01s on Thu, 28 Jul, 11:22 AM Test Summary: 19378 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1424
-
Stefan Froemken uploaded patch set 5 07/28/16, 12:51
-
Markus Klein commented on patch set 5 CR -1 07/28/16, 12:56
@Stefan: Why did you upload set 5? (and change the commit msg again) -
TYPO3com voted on patch set 5 V +1 07/28/16, 12:59 Completed build in 08m 01s on Thu, 28 Jul, 02:59 PM Test Summary: 19378 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1438
-
Stefan Froemken commented on patch set 5 07/28/16, 13:35
Seems, that I have forgotten to reset my core before creating a patch for another issue. Sorry. -
Stefan Froemken updated the commit message in patch set 6 07/28/16, 13:42
-
TYPO3com voted on patch set 6 V +1 07/28/16, 13:51 Completed build in 09m 17s on Thu, 28 Jul, 03:51 PM Test Summary: 19378 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1443
-
Frederic Gaus voted on patch set 6 CR +1 07/28/16, 14:47
-
Markus Klein voted on patch set 6 CR +1 07/28/16, 15:58
-
Wouter Wolters voted on patch set 6 CR +1 07/28/16, 18:58
-
Christian Kuhn commented on patch set 6 07/28/16, 21:00
ah markus, didn't wanted to step on anyone's toes. i read the commit message, was confused, read the forge issue and saw no relation on how the patch could fix the issue. that's why i tried to ask for some more explanation. with the additional text of the commit message this is much more clear now. thank you. -
Markus Klein voted on patch set 6 V +1 07/28/16, 21:03
-
Wouter Wolters commented on patch set 6 CR -1 V -1 07/29/16, 07:06
Nothing is saved for me anymore. -
Wouter Wolters commented on patch set 6 07/29/16, 07:13
SetupModuleController.php:216(!isset($d[$field]) && !isset($d['be_users'][$field])) This will save the data again. -
Wouter Wolters uploaded patch set 7 07/29/16, 07:18
-
TYPO3com voted on patch set 7 V +1 07/29/16, 07:23 Completed build in 05m 49s on Fri, 29 Jul, 09:23 AM Test Summary: 19382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1472
-
Stefan Froemken commented on patch set 7 V -1 07/29/16, 07:45
Now you can't deactivate emailMeAtLogin anymore, because it is a checkbox and has no representation in $d -
Stefan Froemken uploaded patch set 8 07/29/16, 08:17
-
TYPO3com voted on patch set 8 V -1 07/29/16, 08:23 Completed build in 05m 33s on Fri, 29 Jul, 10:23 AM Test Summary: 19382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1474
-
Stefan Froemken commented on patch set 9 07/29/16, 08:43
Published edit on patch set 8. -
TYPO3com voted on patch set 9 V -1 07/29/16, 08:48 Completed build in 05m 01s on Fri, 29 Jul, 10:48 AM Test Summary: 19306 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1476
-
Stefan Froemken uploaded patch set 10 07/29/16, 10:25
-
TYPO3com voted on patch set 10 V +1 07/29/16, 10:29 Completed build in 04m 22s on Fri, 29 Jul, 12:29 PM Test Summary: 19382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1485
-
Markus Klein commented on patch set 11 07/29/16, 12:09
Published edit on patch set 10. -
Markus Klein commented on patch set 11 07/29/16, 12:09
please adjust the message here too -
TYPO3com voted on patch set 11 V -1 07/29/16, 12:18 Completed build in 08m 40s on Fri, 29 Jul, 02:18 PM Test Summary: 19300 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1493
-
Stefan Froemken uploaded patch set 12 07/29/16, 13:42
-
TYPO3com voted on patch set 12 V +1 07/29/16, 13:48 Completed build in 06m 39s on Fri, 29 Jul, 03:48 PM Test Summary: 19378 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1498
-
Markus Klein updated the commit message in patch set 13 07/30/16, 00:21
-
Markus Klein voted on patch set 13 CR +1 07/30/16, 00:22
-
TYPO3com voted on patch set 13 V +1 07/30/16, 00:26 Completed build in 04m 51s on Sat, 30 Jul, 02:26 AM Test Summary: 19378 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1507
-
Markus Klein uploaded patch set 14 07/30/16, 00:37
-
Markus Klein voted on patch set 14 CR +1 07/30/16, 00:37
-
TYPO3com voted on patch set 14 V +1 07/30/16, 00:42 Completed build in 05m 22s on Sat, 30 Jul, 02:42 AM Test Summary: 19378 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1508
-
Jörg Bösche voted on patch set 14 CR +1 09/23/16, 10:04
-
Wouter Wolters voted on patch set 14 CR +1 V +1 09/30/16, 09:32
-
Martin Fox voted on patch set 14 CR +1 V +1 10/07/16, 08:28
-
Markus Klein voted on patch set 14 CR +2 V +2 10/07/16, 09:10
-
Gerrit merged patch set 14 10/07/16, 09:10
-
Markus Klein commented on patch set 15 10/07/16, 09:11
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 4ce7bdf0c745ae77de0ed9c86c0a1a5728e1e143 -
Markus Klein commented on patch set 15 10/07/16, 09:57
Followup in https://review.typo3.org/50100