Review main Merged

49232[TASK] Remove converting pageNotFound_handling in bootstrap

Wouter Wolters CR +2 V +2 Easy +1 −17 updated 07/28/16, 18:36

Commit message

On every request the pageNotFound_handling is casted to a real
boolean if needed. This is not needed and we fix the code execution
to catch this case. We gain not much with this change but makes the
bootstrap smaller.

Review

  • Code review CR +2
    • Benni Mack +2
    • Mathias Schreiber +1
  • Verified V +2
    • Benni Mack +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 67

  1. Wouter Wolters uploaded patch set 1 07/28/16, 07:58

  2. TYPO3com voted on patch set 1 V +1 07/28/16, 08:04 Completed build in 05m 09s on Thu, 28 Jul, 10:04 AM Test Summary: 19378 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1421

  3. Mathias Schreiber commented on patch set 1 07/28/16, 17:24

    There are usages of that setting in typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php which just check for boolean true. Could this be a problem?
  4. Wouter Wolters commented on patch set 1 07/28/16, 18:24

    all these checks do a check if there is something set in the setting. A filled string is also true.
  5. Mathias Schreiber voted on patch set 1 CR +1 V +1 07/28/16, 18:27

  6. Benni Mack voted on patch set 1 CR +2 V +2 07/28/16, 18:36

  7. Gerrit merged patch set 1 07/28/16, 18:36