Review main Merged

49241[BUGFIX] Fix condition for USERDEF2 in procesItemState

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 07/28/16, 19:54

Commit message

Fix a wrong condition in the procesItemState method for MENU handling
for the USERDEF2 itemstate, so it would not be ignored anymore.

Initializing the USERDEF2conf was never done, even if one or more
USERDEF2 item states was found, because the condition was checking
for NULL === TRUE, which will never be TRUE.

Review

  • Code review CR +2
    • Susi Moog +2
    • Wouter Wolters +1
    • Markus Klein +1
  • Verified V +2
    • Susi Moog +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Stefan Bürk uploaded patch set 1 07/28/16, 10:40

  2. TYPO3com voted on patch set 1 V +1 07/28/16, 10:45 Completed build in 04m 56s on Thu, 28 Jul, 12:45 PM Test Summary: 19378 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1429

  3. Wouter Wolters updated the commit message in patch set 2 07/28/16, 14:18

  4. TYPO3com voted on patch set 2 V +1 07/28/16, 14:26 Completed build in 08m 23s on Thu, 28 Jul, 04:26 PM Test Summary: 19378 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1445

  5. Markus Klein commented on patch set 2 CR +1 V +1 07/28/16, 19:40

    no-brainer actually, same as USERDEF1
  6. Wouter Wolters voted on patch set 2 CR +1 07/28/16, 19:46

  7. Susi Moog voted on patch set 2 CR +2 V +2 07/28/16, 19:54

  8. Gerrit merged patch set 2 07/28/16, 19:54

  9. Susi Moog commented on patch set 3 07/28/16, 19:54

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 98aa32e6a1e57858ba33839028083b61d40e26d7