49248[!!!][BUGFIX] Remove non core table list from fluid_styled_content
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Andreas Kienast +1
- Oliver Hader +1
- Benni Mack +1
-
Verified V +2
- Anja Leichsenring +2
- Oliver Hader +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1316
-
Georg Ringer uploaded patch set 1 07/28/16, 12:42
-
Wouter Wolters voted on patch set 1 CR +1 07/28/16, 12:43
-
TYPO3com voted on patch set 1 V +1 07/28/16, 12:48 Completed build in 05m 31s on Thu, 28 Jul, 02:48 PM Test Summary: 19378 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1437
-
Susi Moog commented on patch set 1 CR -1 07/28/16, 13:16
isn't this a breaking change? as if you are using shortcuts for tt_address that won't work anymore? I'd at least add a .rst file about it. -
Georg Ringer uploaded patch set 2 07/28/16, 15:34
-
TYPO3com voted on patch set 2 V +1 07/28/16, 15:43 Completed build in 08m 11s on Thu, 28 Jul, 05:43 PM Test Summary: 19378 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1449
-
Frans Saris commented on patch set 2 07/28/16, 17:47
IMO this isn't a fix but a workaround. Can't we add a check based on the presence of the table in TCA? -
Susi Moog commented on patch set 2 CR +1 V +1 07/29/16, 06:28
@Frans: I think it's cleaner this way, as the tables should by default only be core tables. But yes, it would be cleaner to check for table existence based on TCA - but that would be sanity checking for typoscript configuration (which could be done at a thousand places more ;)). From my point of view the patch is ok this way, as it is better than it was before. -
Benni Mack commented on patch set 3 08/01/16, 14:54
Published edit on patch set 2. -
Benni Mack voted on patch set 3 CR +1 08/01/16, 14:54
-
Andreas Kienast voted on patch set 3 CR +1 08/01/16, 14:56
-
TYPO3com voted on patch set 3 V +1 08/01/16, 15:04 Completed build in 10m 05s on Mon, 1 Aug, 05:04 PM Test Summary: 19380 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1533
-
Oliver Hader voted on patch set 3 CR +1 08/02/16, 07:48
-
Oliver Hader voted on patch set 3 V +1 08/02/16, 10:31
-
Anja Leichsenring voted on patch set 3 CR +2 V +2 08/02/16, 10:31
-
Gerrit merged patch set 3 08/02/16, 10:32