Review main Abandoned

49249[BUGFIX] Installer throws exception while connecting to wrong MySQL

Stefan Froemken CR 0 V 0 Normal +1 −65 updated 09/02/16, 15:18

Commit message

One some server the default value 127.0.0.1 represents a MySQL 3
Server. While connecting to that server with mysqli an
exception will be thrown.
Suggesting DB parameters is not our goal. We have removed that
part and customer has to enter the credentials again.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 57

  1. Stefan Froemken uploaded patch set 1 07/28/16, 12:51

  2. Andreas Kienast updated the commit message in patch set 2 07/28/16, 12:57

  3. TYPO3com voted on patch set 1 V +1 07/28/16, 13:06 Completed build in 10m 28s on Thu, 28 Jul, 03:06 PM Test Summary: 19378 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1439

  4. TYPO3com voted on patch set 2 V +1 07/28/16, 13:11 Completed build in 10m 38s on Thu, 28 Jul, 03:11 PM Test Summary: 19378 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1440

  5. Christian Kuhn commented on patch set 2 08/31/16, 16:15

    I'd actually like it better if the according exception / error message is handled in a good way. This way we could keep the rather convenient auto-search of databases.
  6. Jigal van Hemert commented on patch set 2 CR -1 08/31/16, 19:42

    It looks like the exception isn't somehow caught. This part of the Install Tool will be rewritten before 8 LTS. It's good that we're now aware that the exception handling needs to be checked more thoroughly.
  7. Wouter Wolters abandoned the change 09/02/16, 15:18

    This has been fixed in master. Tested on jweiland infrastructure