Review main Merged

49260[BUGFIX] Adding back access to parentMenuArr and menuitem in subMenu

Stefan Bürk CR +2 V +2 Normal +133 −0 updated 10/25/16, 20:32

Commit message

Adding the possibility to access the menuArr and direct menuItem from
the parent menu in subMenu instances to provide the ability to check
for parent item information or parent sibling item informations.

Providing two getters and a combined setter, called in the subMenu
method to readd this data access instead of simple using the old
unsafe and undeclared property set.

Leaving the parentMenuArr member public for now, even it is not
nice.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2736

Show 811 earlier messages
  1. Stefan Bürk uploaded patch set 1 07/29/16, 07:55

  2. TYPO3com voted on patch set 1 V -1 07/29/16, 08:04 Completed build in 09m 08s on Fri, 29 Jul, 10:04 AM Test Summary: 19382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1473

  3. Stefan Bürk uploaded patch set 2 07/29/16, 09:10

  4. TYPO3com voted on patch set 2 V +1 07/29/16, 09:19 Completed build in 08m 16s on Fri, 29 Jul, 11:19 AM Test Summary: 19382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1477

  5. Andreas Kienast commented on patch set 2 07/29/16, 09:22

    There are minor code style issues, I'll pick them up
  6. Andreas Kienast commented on patch set 2 CR -1 07/29/16, 09:23

    -1 for the time being
  7. Andreas Kienast uploaded patch set 3 07/29/16, 09:26

  8. Andreas Kienast uploaded patch set 4 07/29/16, 09:28

  9. TYPO3com voted on patch set 4 V +1 07/29/16, 09:36 Completed build in 07m 51s on Fri, 29 Jul, 11:36 AM Test Summary: 19382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1479

  10. Stefan Bürk commented on patch set 4 08/03/16, 19:32

    Updates the issue and added a test extension for reproducing the issue and for testing the patch (bugfix) and the additional new getters.
  11. Stefan Bürk uploaded patch set 5 08/03/16, 20:41

  1. TYPO3com voted on patch set 5 V +1 08/03/16, 20:44 Completed build in 03m 03s on Wed, 3 Aug, 10:44 PM Test Summary: 18515 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1770

  2. Georg Ringer commented on patch set 5 08/04/16, 09:46

    AbstractMenuContentObject.php:237

    why public?
  3. Stefan Bürk commented on patch set 5 08/04/16, 11:06

    In 6.2 this was a undefined public member, set before rendering a subMenu. Had a talk with Matthias Schreiber, and the point was to bring this back, because it has silently broked itemArrayProcFunc usage. And provide some getter/setter as the "new" way, so the public can be changed to protected in the future. Had this initially, but changed it to public after the chat with Matthias.
  4. Anja Leichsenring voted on patch set 5 CR +1 V +1 08/04/16, 12:15

  5. Andreas Wolf commented on patch set 5 09/01/16, 13:00

    Shouldn’t the "public" be marked as deprecated then and we drop it in CMS 9?
  6. Andreas Wolf commented on patch set 5 CR -1 09/01/16, 13:03

    There’s a few quirks in the code I’d like to see fixed.

    AbstractMenuContentObject.php:2257

    Can we have a textual description (i.e. comment) on what this does? I surely can read and understand it, but it takes time and clutters my mind.

    AbstractMenuContentObject.php:2270

    Can we move this check to a separate method? AFAIS this is the submenu check, right?

    AbstractMenuContentObject.php:2285

    This is far too complex IMHO to be understandable at a glance.
  7. Andreas Wolf commented on patch set 5 09/01/16, 13:20

    AbstractMenuContentObject.php:2257 Reply

    Ok, after having a closer look while drafting a comment, I do not understand it. If the variable is not empty, the inner block will be true, and it will be true for a 0, which !empty() would not cover. But I don’t get the intention of the !empty() here.
  8. Stefan Bürk uploaded patch set 6 09/01/16, 15:18

  9. TYPO3com voted on patch set 6 V -1 09/01/16, 15:22 Completed build in 03m 13s on Thu, 1 Sep, 05:22 PM Test Summary: 19100 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2648

  10. Stefan Bürk uploaded patch set 7 09/01/16, 15:27

  11. TYPO3com voted on patch set 7 V +1 09/01/16, 15:30 Completed build in 03m 17s on Thu, 1 Sep, 05:30 PM Test Summary: 19100 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2649

  12. Stefan Bürk commented on patch set 7 09/01/16, 15:33

    > Shouldn’t the "public" be marked as deprecated then and we drop it > in CMS 9? Added deprecation notice
  13. Anja Leichsenring commented on patch set 8 10/06/16, 16:19

    Published edit on patch set 7.
  14. Anja Leichsenring voted on patch set 8 CR +1 V +1 10/06/16, 16:22

  15. TYPO3com voted on patch set 8 V +1 10/06/16, 16:22 Completed build in 03m 18s on Thu, 6 Oct, 06:22 PM Test Summary: 18535 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3343

  16. Frank Nägler commented on patch set 8 CR -1 10/07/16, 11:02

    please use our "default wording" for deprecations. And this patch need a deprecation rst file.

    AbstractMenuContentObject.php:236

    please use the default wording: @deprecated since TYPO3 v8, will be removed in TYPO3 v9, please use getter and setter methods.
  17. Stefan Bürk uploaded patch set 9 10/23/16, 22:40

  18. Stefan Bürk commented on patch set 9 10/23/16, 22:43

    Added a deprecation rst and changed the wording of the deprectation docblock.
  19. TYPO3com voted on patch set 9 V +1 10/23/16, 22:45 Completed build in 04m 49s on Mon, 24 Oct, 12:45 AM Test Summary: 19561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4036

  20. Anja Leichsenring commented on patch set 10 10/25/16, 11:47

    Published edit on patch set 9.
  21. Anja Leichsenring voted on patch set 10 CR +1 V +1 10/25/16, 11:47

  22. TYPO3com voted on patch set 10 V +1 10/25/16, 11:52 Completed build in 04m 53s on Tue, 25 Oct, 01:52 PM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4134

  23. Christian Kuhn voted on patch set 10 CR +2 V +2 10/25/16, 20:31

  24. Gerrit merged patch set 10 10/25/16, 20:32

  25. Christian Kuhn commented on patch set 11 10/25/16, 20:32

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 7a1289303933aa7b1a98393871a485b1e88d3d37