Review main Merged

49272[BUGFIX] Change event listening in jquery.minicolors and disable grunt copy

Andreas Kienast CR +2 V +2 Expert +1130 −1 updated 08/04/16, 11:45

Commit message

A bug in the jquery.minicolors library prevents the generation in an frame
and proper representation in the global document, as the library listens
to events in the frame (`document`) only, but the elements placed are in
`top.document`. Due to this, the event listening is changed and the grunt
copy command for this file is disabled to prevent overriding the library.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Georg Ringer +1
    • Wouter Wolters +1
  • Verified V +2
    • Anja Leichsenring +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 912

  1. Andreas Kienast uploaded patch set 1 07/31/16, 11:09

  2. Andreas Kienast uploaded patch set 2 07/31/16, 11:11

  3. TYPO3com voted on patch set 1 V +1 07/31/16, 11:15 Completed build in 06m 36s on Sun, 31 Jul, 01:15 PM Test Summary: 19378 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1510

  4. TYPO3com voted on patch set 2 V +1 07/31/16, 11:16 Completed build in 04m 37s on Sun, 31 Jul, 01:16 PM Test Summary: 19378 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1511

  5. Georg Ringer commented on patch set 2 08/01/16, 05:27

    Gruntfile.js:223

  6. Andreas Kienast uploaded patch set 3 08/01/16, 07:04

  7. Andreas Kienast commented on patch set 3 08/01/16, 07:04

    Gruntfile.js:223 Reply

    Both are correct, the #206 ticket was created afterwards. I'll update the comment
  8. TYPO3com voted on patch set 3 V +1 08/01/16, 07:08 Completed build in 04m 31s on Mon, 1 Aug, 09:08 AM Test Summary: 19378 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1514

  9. Georg Ringer voted on patch set 3 CR +1 V +1 08/01/16, 08:06

  10. Wouter Wolters voted on patch set 3 CR +1 08/02/16, 12:22

  11. Anja Leichsenring voted on patch set 3 CR +2 V +2 08/04/16, 11:45

  12. Gerrit merged patch set 3 08/04/16, 11:45