Review main Merged

49286[TASK] Add integrity test for LocalizationUtility

Anja Leichsenring CR +2 V +2 Easy +16 −0 updated 08/02/16, 14:55

Commit message

A cross dependency in unit tests has been discovered. To make sure
there are no more of this, an integrity test has been added. In makes
sure the configurationManager property of this class is still null.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 915

  1. Anja Leichsenring uploaded patch set 1 08/01/16, 15:25

  2. Christian Kuhn commented on patch set 1 08/01/16, 15:29

    looks good, should be ok if the typos are fixed.
    localization
    integrity

    IntegrityTest.php:49

    localization
  3. TYPO3com voted on patch set 1 V -1 08/01/16, 15:30 Completed build in 05m 09s on Mon, 1 Aug, 05:30 PM Test Summary: 2 of 19382 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1534

  4. Anja Leichsenring commented on patch set 2 08/01/16, 15:32

    Published edit on patch set 1.
  5. TYPO3com voted on patch set 2 V -1 08/01/16, 15:37 Completed build in 05m 05s on Mon, 1 Aug, 05:37 PM Test Summary: 2 of 19382 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1535

  6. Christian Kuhn updated the commit message in patch set 3 08/01/16, 16:20

  7. Christian Kuhn rebased onto patch set 4 08/01/16, 16:20

  8. TYPO3com voted on patch set 3 V -1 08/01/16, 16:29 Completed build in 08m 39s on Mon, 1 Aug, 06:29 PM Test Summary: 2 of 19382 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1543

  9. TYPO3com voted on patch set 4 V -1 08/01/16, 16:32 Completed build in 07m 27s on Mon, 1 Aug, 06:32 PM Test Summary: 2 of 19382 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1544

  10. Anja Leichsenring rebased onto patch set 5 08/02/16, 08:48

  11. TYPO3com voted on patch set 5 V -1 08/02/16, 08:52 Completed build in 04m 12s on Tue, 2 Aug, 10:52 AM Test Summary: 2 of 19382 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1561

  12. Anja Leichsenring uploaded patch set 6 08/02/16, 14:44

  13. TYPO3com voted on patch set 6 V +1 08/02/16, 14:50 Completed build in 05m 43s on Tue, 2 Aug, 04:50 PM Test Summary: 18515 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1597

  14. Christian Kuhn voted on patch set 6 CR +2 V +2 08/02/16, 14:55

  15. Gerrit merged patch set 6 08/02/16, 14:55