Review main Merged

49287[TASK] Improve TranslateViewHelperTest

Anja Leichsenring CR +2 V +2 Easy +13 −7 updated 08/01/16, 16:19

Commit message

Use Fixture class instead original in order to prevent
static call to LocalizationUtility::translate().

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Sebastian Bumann +1
  • Verified V +2
    • Christian Kuhn +2
    • Sebastian Bumann +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 811

  1. Anja Leichsenring uploaded patch set 1 08/01/16, 15:36

  2. TYPO3com voted on patch set 1 V -1 08/01/16, 15:41 Completed build in 04m 47s on Mon, 1 Aug, 05:41 PM Test Summary: 19380 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1536

  3. Christian Kuhn updated the commit message in patch set 2 08/01/16, 15:57

  4. Christian Kuhn commented on patch set 2 08/01/16, 16:01

    TranslateViewHelperTest.php:30

    empty setUp() no longer needed
  5. TYPO3com voted on patch set 2 V -1 08/01/16, 16:02 Completed build in 04m 37s on Mon, 1 Aug, 06:02 PM Test Summary: 19380 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1539

  6. Christian Kuhn uploaded patch set 3 08/01/16, 16:02

  7. Christian Kuhn voted on patch set 3 CR +1 V +1 08/01/16, 16:03

  8. Sebastian Bumann voted on patch set 3 CR +1 V +1 08/01/16, 16:05

  9. TYPO3com voted on patch set 3 V +1 08/01/16, 16:11 Completed build in 08m 43s on Mon, 1 Aug, 06:11 PM Test Summary: 19380 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1541

  10. Christian Kuhn voted on patch set 3 CR +2 V +2 08/01/16, 16:19

  11. Gerrit merged patch set 3 08/01/16, 16:19