Review main Merged

49289[FEATURE] Allow unit string as viewhelper argument

Anja Leichsenring CR +2 V +2 Normal +51 −30 updated 08/02/16, 14:40

Commit message

The ByteViewHelper accepts a parameter 'units' in order to provide
a custom collection of units.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Sebastian Bumann +1
  • Verified V +2
    • Christian Kuhn +2
    • Sebastian Bumann +1

Issues 1

Files 3

Review log 1418

  1. Anja Leichsenring uploaded patch set 1 08/01/16, 15:57

  2. TYPO3com voted on patch set 1 V -1 08/01/16, 16:03 Completed build in 04m 18s on Mon, 1 Aug, 06:03 PM Test Summary: 19380 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1540

  3. Anja Leichsenring uploaded patch set 2 08/02/16, 07:41

  4. TYPO3com voted on patch set 2 V +1 08/02/16, 07:46 Completed build in 05m 23s on Tue, 2 Aug, 09:46 AM Test Summary: 19380 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1550

  5. Anja Leichsenring uploaded patch set 3 08/02/16, 07:52

  6. TYPO3com voted on patch set 3 V -1 08/02/16, 07:56 Completed build in 02m 10s on Tue, 2 Aug, 09:56 AM Test Summary: 62 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1552

  7. Andreas Kienast commented on patch set 3 CR -1 08/02/16, 08:07

    Feature ReST missing and conflicting
  8. Anja Leichsenring commented on patch set 3 08/02/16, 08:07

    this patch depends on https://review.typo3.org/#/c/48927, please apply that first.
  9. Anja Leichsenring uploaded patch set 4 08/02/16, 08:22

  10. TYPO3com voted on patch set 4 V -1 08/02/16, 08:25 Completed build in 01m 40s on Tue, 2 Aug, 10:25 AM Test Summary: 62 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1557

  11. Anja Leichsenring uploaded patch set 5 08/02/16, 12:13

  12. Anja Leichsenring uploaded patch set 6 08/02/16, 12:17

  13. Anja Leichsenring commented on patch set 7 08/02/16, 14:05

    Published edit on patch set 6.
  14. Christian Kuhn commented on patch set 6 08/02/16, 14:06

    Feature-77336-AllowPassingAnOwnUnitCollectionToByteViewHelper.rst:13

    example list for custom units missing
  15. Christian Kuhn voted on patch set 7 CR +1 V +1 08/02/16, 14:08

  16. Sebastian Bumann voted on patch set 7 CR +1 V +1 08/02/16, 14:36

  17. Christian Kuhn voted on patch set 7 CR +2 V +2 08/02/16, 14:40

  18. Gerrit merged patch set 7 08/02/16, 14:40