Review main Merged

49295[BUGFIX] Use special treatment for language field in RelationHandler

Markus Mächler CR +2 V +2 Normal +80 −1 updated 08/15/16, 15:17

Commit message

This fixes saving the default language in BE user group permissions.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Markus Klein +1
  • Verified V +2
    • Oliver Hader +2
    • TYPO3com +1 CI

Files 3

Review log 2937

Show 1012 earlier messages
  1. Markus Mächler uploaded patch set 1 08/02/16, 07:19

  2. TYPO3com voted on patch set 1 V +1 08/02/16, 07:23 Completed build in 04m 10s on Tue, 2 Aug, 09:23 AM Test Summary: 19380 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1549

  3. Markus Klein commented on patch set 1 08/02/16, 08:57

    RelationHandler.php:410

    can be shortened to !empty()

    be_groups.php:205

    This is a feature and can therefore only go in master branch. Of course appropriate documentation is required (RST).
  4. Markus Mächler uploaded patch set 2 08/02/16, 09:23

  5. TYPO3com voted on patch set 2 V +1 08/02/16, 09:31 Completed build in 08m 23s on Tue, 2 Aug, 11:31 AM Test Summary: 19380 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1565

  6. Oliver Hader commented on patch set 2 CR -1 08/02/16, 09:34

    I'd opt to have tests for that and also to avoid cluttering specific TCA checks among the core... I'm going to have a look into that.
  7. Markus Mächler commented on patch set 2 08/02/16, 09:38

    > I'd opt to have tests for that and also to avoid cluttering > specific TCA checks among the core... I'm going to have a look into > that. true, I tried to introduce a configuration option for allowing empty Ids, which was rejected to be included into 7.6 since it is a new feature. therefore I included the specific check to avoid having to introduce new features. moreover, the sys_language table should be the only place with a zero-valued uid.

    be_groups.php:205 Reply

    how else should I do it to have it in TYPO3 7.6? This is a bug and needs to be fixed.
  8. Susi Moog commented on patch set 2 08/02/16, 10:17

    As the analysis in the ticket states this is actually an issue not only concerning languages but datahandler handling/storing empty values therefor I'd prefer a more general solution here. I can dimly remember having the same problem with a "normal" select field not too long ago, but I can't actually find the issue again.
  9. Markus Mächler commented on patch set 2 08/02/16, 13:38

    so how do you want to proceed?
  10. Markus Klein commented on patch set 2 08/09/16, 10:46

    @Olly: In according to my analysis in the ticket we fail hard here on storing 0 in foreign_table situations. Since languages are special anyway we need to the check for this specialty anyways. I had to add such checks at other places too. I would agree to fix it for the given case with the proposed fix and to add generic processing of 0 with foreign table at a later point.
  11. Markus Klein updated the commit message in patch set 3 08/09/16, 10:48

  12. Markus Klein updated the commit message in patch set 4 08/09/16, 10:48

  1. Markus Klein voted on patch set 4 CR +1 08/09/16, 10:48

  2. TYPO3com voted on patch set 3 V +1 08/09/16, 10:55 Completed build in 06m 39s on Tue, 9 Aug, 12:55 PM Test Summary: 18474 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1951

  3. TYPO3com voted on patch set 4 V +1 08/09/16, 10:58 Completed build in 09m 38s on Tue, 9 Aug, 12:58 PM Test Summary: 18474 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1952

  4. Daniel Goerz voted on patch set 4 CR +1 V +1 08/10/16, 16:06

  5. Oliver Hader uploaded patch set 5 08/15/16, 14:17

  6. Oliver Hader voted on patch set 5 CR +1 V +1 08/15/16, 14:18

  7. TYPO3com voted on patch set 5 V -1 08/15/16, 14:20 Completed build in 02m 52s on Mon, 15 Aug, 04:20 PM Test Summary: 18690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2062

  8. Oliver Hader uploaded patch set 6 08/15/16, 14:22

  9. Markus Mächler commented on patch set 5 08/15/16, 14:23

    > Uploaded patch set 5. hey oliver the double isset ternary operator does not work for PHP7, therefore for typo3 7.6 you need to use isset()

    RelationHandler.php:415

    this is a PHP7 feature, therefore not applicable for 7.6, why don't you just use isset() || ==? https://wiki.php.net/rfc/isset_ternary
  10. TYPO3com voted on patch set 6 V +1 08/15/16, 14:25 Completed build in 02m 54s on Mon, 15 Aug, 04:25 PM Test Summary: 18690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2063

  11. Oliver Hader commented on patch set 6 08/15/16, 14:26

    I guess you mean "not for PHP 5.5" which is correct. However, this patch is for master and thus for PHP7... Back-port is a different thing
  12. Markus Mächler commented on patch set 6 08/15/16, 14:27

    ah, ok, thanks for your effort!
  13. Oliver Hader uploaded patch set 7 08/15/16, 14:32

  14. Oliver Hader commented on patch set 6 08/15/16, 14:32

    Reduced test case a bit by using data-provider
  15. Oliver Hader voted on patch set 7 CR +1 V +1 08/15/16, 14:33

  16. TYPO3com voted on patch set 7 V +1 08/15/16, 14:35 Completed build in 03m 19s on Mon, 15 Aug, 04:35 PM Test Summary: 18690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2064

  17. Oliver Hader commented on patch set 7 CR -1 08/15/16, 14:39

    Sorry, forgot something to amend
  18. Oliver Hader uploaded patch set 8 08/15/16, 14:41

  19. Oliver Hader commented on patch set 8 CR +1 V +1 08/15/16, 14:41

    Finally... ;-)
  20. TYPO3com voted on patch set 8 V +1 08/15/16, 14:44 Completed build in 02m 37s on Mon, 15 Aug, 04:44 PM Test Summary: 18690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2066

  21. Benni Mack commented on patch set 8 08/15/16, 14:46

    please be aware that ?? is PHP7 only http://php.net/manual/de/migration70.new-features.php
  22. Oliver Hader commented on patch set 8 08/15/16, 14:50

    Benni, sure, read comments some minutes ago please
  23. Markus Klein voted on patch set 8 CR +1 08/15/16, 15:04

  24. Oliver Hader voted on patch set 8 CR +2 V +2 08/15/16, 15:17

  25. Gerrit merged patch set 8 08/15/16, 15:17