Review TYPO3_7-6 Merged Breaking

49305[!!!][BUGFIX] Rename configuration for confirmation view

Anja Leichsenring CR +2 V +2 Easy +36 −3 updated 08/02/16, 12:40

Commit message

The configuration key for the confirmation layout has been renamed
from confirmation.layout to confirmationView.layout.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Markus Hölzle +1
    • Björn Jacob +1
  • Verified V +2
    • Anja Leichsenring +2
    • Markus Hölzle +1
    • Björn Jacob +1

Issues 1

Files 3

Review log 14

  1. Anja Leichsenring commented on patch set 1 08/02/16, 11:14

    Cherry Picked from branch master.
  2. Anja Leichsenring commented on patch set 1 CR +1 V +1 08/02/16, 11:16

    not my patch, I just pushed it to the correct branch. Original patch for master is abandoned, it is not needed there.
  3. Markus Hölzle voted on patch set 1 CR +1 V +1 08/02/16, 11:30

  4. Mathias Brodala commented on patch set 1 CR -1 08/02/16, 11:30

    A breaking change within a LTS release? Is that really what we want?
  5. Anja Leichsenring commented on patch set 1 08/02/16, 11:36

    Mathias, without that change the confirmation feature of ext:form is broken completely. Having confirmation enabled and using the configuration, too, will lead to no confirmation at all. The impact should be low, though, as the confirmation configuration possiblity has never been documented.
  6. Björn Jacob commented on patch set 2 08/02/16, 11:44

    Published edit on patch set 1.
  7. Anja Leichsenring voted on patch set 2 CR +1 V +1 08/02/16, 11:48

  8. Ralf Zimmermann uploaded patch set 3 08/02/16, 12:33

  9. Mathias Brodala commented on patch set 2 CR +1 08/02/16, 12:34

    > Mathias, without that change the confirmation feature of ext:form > is broken completely. Having confirmation enabled and using the > configuration, too, will lead to no confirmation at all. > > The impact should be low, though, as the confirmation configuration > possiblity has never been documented. OK, so fine with me. :-)
  10. Björn Jacob voted on patch set 3 CR +1 V +1 08/02/16, 12:36

  11. Anja Leichsenring voted on patch set 3 CR +1 V +1 08/02/16, 12:36

  12. Markus Hölzle voted on patch set 3 CR +1 V +1 08/02/16, 12:39

  13. Anja Leichsenring voted on patch set 3 CR +2 V +2 08/02/16, 12:40

  14. Gerrit merged patch set 3 08/02/16, 12:40