Review main Merged

49306[FEATURE] Allow additional paths for extension icons

Benni Mack CR +2 V +2 Easy +38 −8 updated 08/03/16, 14:29

Commit message

Until now, the extension icon had to be located under ext_icon.png,
ext_icon.svg, ext_icon.gif within the extension directory.

In order to prepare a way to allow only files under Resources/Public/
to be public, the icon can now also be put under
Resources/Public/Icons/Extension.png or .svg

Several paths where hard-coded extension icon paths are replaced
with the getExtensionIcon() API in the Core.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Georg Ringer +1
  • Verified V +2
    • Anja Leichsenring +2
    • Georg Ringer +1

Issues 1

Files 5

Review log 67

  1. Benni Mack uploaded patch set 1 08/02/16, 11:14

  2. TYPO3com voted on patch set 1 V +1 08/02/16, 11:23 Completed build in 06m 26s on Tue, 2 Aug, 01:23 PM Test Summary: 19380 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1580

  3. Benni Mack uploaded patch set 2 08/02/16, 14:07

  4. Georg Ringer voted on patch set 2 CR +1 V +1 08/03/16, 07:35

  5. Anja Leichsenring voted on patch set 2 CR +1 V +1 08/03/16, 14:28

  6. Anja Leichsenring voted on patch set 2 CR +2 V +2 08/03/16, 14:28

  7. Gerrit merged patch set 2 08/03/16, 14:29