Review main Merged

49331[BUGFIX] Allow array of paths in psr-4 autoload definition

Helmut Hummel CR +2 V +2 Easy +28 −13 updated 08/02/16, 21:00

Commit message

When defining a namespace prefix for psr-4 autoload in composer.json,
it is possible to specify multiple paths as array.

Thus, we must handle the array case properly and not falsely assume
that there is only a path string.

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Helmut Hummel +2
    • Wouter Wolters +1
    • Markus Klein +1
  • Verified V +2
    • Nicole Hummel +2
    • Helmut Hummel +2
    • Wouter Wolters +1
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 910

  1. Helmut Hummel uploaded patch set 1 08/02/16, 19:31

  2. Wouter Wolters voted on patch set 1 CR +1 08/02/16, 19:32

  3. TYPO3com voted on patch set 1 V +1 08/02/16, 19:35 Completed build in 03m 55s on Tue, 2 Aug, 09:35 PM Test Summary: 18517 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1629

  4. Markus Klein voted on patch set 1 CR +1 V +1 08/02/16, 19:35

  5. Wouter Wolters voted on patch set 1 V +1 08/02/16, 19:36

  6. Helmut Hummel commented on patch set 1 CR -2 08/02/16, 19:50

    Thanks for the rapid reviews! Waiting for Nicole to have a final look.
  7. Nicole Hummel voted on patch set 1 CR +2 V +2 08/02/16, 20:52

  8. Helmut Hummel voted on patch set 1 CR +2 V +2 08/02/16, 21:00

  9. Gerrit merged patch set 1 08/02/16, 21:00

  10. Helmut Hummel commented on patch set 2 08/02/16, 21:00

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 37455ed2c9a9e150de50aab57f9ad43691cff25f