Review main Merged

49357[TASK] Refactor functional tests migrated in #77381

Thomas Schlumberger CR +2 V +2 Easy +6 −42 updated 08/03/16, 17:12

Commit message

This patch refactors the tests migrated from unit tests in #77381.
The tests make now use of the fixture functionality to write a
ResourceStorage to the db and get it via the StorageRepository
instead of creating the object via "new".

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 46

  1. Thomas Schlumberger uploaded patch set 1 08/03/16, 16:43

  2. TYPO3com voted on patch set 1 V -1 08/03/16, 16:46 Completed build in 02m 38s on Wed, 3 Aug, 06:46 PM Test Summary: 18515 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1729

  3. Thomas Schlumberger uploaded patch set 2 08/03/16, 17:01

  4. TYPO3com voted on patch set 2 V +1 08/03/16, 17:06 Completed build in 04m 22s on Wed, 3 Aug, 07:06 PM Test Summary: 18515 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1732

  5. Christian Kuhn voted on patch set 2 CR +2 V +2 08/03/16, 17:12

  6. Gerrit merged patch set 2 08/03/16, 17:12