Review main Merged

49369[TASK] EXT:sysext: enlarge column field in sys_refindex to 64 chars

Jörg Bösche CR +2 V +2 Easy +1 −1 updated 08/04/16, 09:04

Commit message

Concern extension "sysext".

Additional field names in the database tables, which are greater than
40 characters are not completely saved. Often new columns have an
extension prefix and a name.
e.g. tx_myextension_model_tags_customFieldName
Since MySQL 5.5+ it is possible to define database table name
columns with 64 characters.

The fix is for the master branch and backporting the version 7.6 LTS.
Version 7.6 LTS requires MySQL version 5.5+.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Georg Ringer +1
  • Verified V +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Jörg Bösche uploaded patch set 1 08/03/16, 21:23

  2. TYPO3com voted on patch set 1 V +1 08/03/16, 21:26 Completed build in 02m 32s on Wed, 3 Aug, 11:26 PM Test Summary: 18515 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1773

  3. Jörg Bösche updated the commit message in patch set 2 08/03/16, 21:27

  4. Jörg Bösche commented on patch set 2 08/03/16, 21:30

    Tested with MySQL version 5.7.12 and 5.5.47.
  5. TYPO3com voted on patch set 2 V +1 08/03/16, 21:30 Completed build in 02m 46s on Wed, 3 Aug, 11:30 PM Test Summary: 18515 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1774

  6. Georg Ringer voted on patch set 2 CR +1 V +1 08/04/16, 08:33

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 08/04/16, 08:35

  8. Gerrit merged patch set 2 08/04/16, 08:35

  9. Christian Kuhn commented on patch set 3 08/04/16, 08:35

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 006b9c54b197e7c4c4223ee93a13a30870288546
  10. Oliver Klee commented on patch set 2 08/04/16, 08:35

    You're referring to the extension "core", not "sysext", right?
  11. Benni Mack commented on patch set 3 08/04/16, 09:04

    what kind of commit message is that?