Review main Merged

49380[TASK] Deprecate TemplateService->fileContent

Benni Mack CR +2 V +2 Easy +29 −2 updated 08/10/16, 19:11

Commit message

The fileContent method is not used anymore, and can cleanly
be deprecated. It should not be part of the TemplateService
as it is not related to that very much anymore.

Extension authors should implement this method on their own.

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Georg Ringer +1
  • Verified V +2
    • Morton Jonuschat +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 57

  1. Benni Mack uploaded patch set 1 08/04/16, 12:49

  2. TYPO3com voted on patch set 1 V +1 08/04/16, 12:52 Completed build in 02m 39s on Thu, 4 Aug, 02:52 PM Test Summary: 18515 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1814

  3. Benni Mack uploaded patch set 2 08/10/16, 18:46

  4. TYPO3com voted on patch set 2 V +1 08/10/16, 18:50 Completed build in 04m 10s on Wed, 10 Aug, 08:50 PM Test Summary: 18668 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1979

  5. Georg Ringer voted on patch set 2 CR +1 V +1 08/10/16, 18:57

  6. Morton Jonuschat voted on patch set 2 CR +2 V +2 08/10/16, 19:11

  7. Gerrit merged patch set 2 08/10/16, 19:11