Review main Merged

49389[BUGFIX] Make EXT:filemetadata work with MySQL strict mode

Benni Mack CR +2 V +2 Easy +22 −22 updated 08/05/16, 13:50

Commit message

EXT:filemetadata delivers a lot of sys_file_metadata fields
with NOT NULL in it, which does not make sense.

MySQL strict mode does not work with this SQL definition.

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Wouter Wolters +1
    • Thomas Schlumberger +1
  • Verified V +2
    • Morton Jonuschat +2
    • Thomas Schlumberger +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1012

  1. Benni Mack uploaded patch set 1 08/05/16, 13:15

  2. Andreas Kienast commented on patch set 2 08/05/16, 13:16

    Published edit on patch set 1.
  3. TYPO3com voted on patch set 1 V +1 08/05/16, 13:19 Completed build in 03m 54s on Fri, 5 Aug, 03:19 PM Test Summary: 18505 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1860

  4. TYPO3com voted on patch set 2 V +1 08/05/16, 13:20 Completed build in 03m 58s on Fri, 5 Aug, 03:20 PM Test Summary: 18505 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1861

  5. Morton Jonuschat voted on patch set 2 CR +1 V +1 08/05/16, 13:21

  6. Wouter Wolters commented on patch set 2 CR +1 08/05/16, 13:24

    I know one related ticket that talks about this as well... need to look it up
  7. Wouter Wolters commented on patch set 2 08/05/16, 13:25

  8. Thomas Schlumberger voted on patch set 2 CR +1 V +1 08/05/16, 13:26

  9. Benni Mack commented on patch set 2 08/05/16, 13:26

    marginally related, IMHO.
  10. Morton Jonuschat voted on patch set 2 CR +2 V +2 08/05/16, 13:49

  11. Gerrit merged patch set 2 08/05/16, 13:49

  12. Morton Jonuschat commented on patch set 3 08/05/16, 13:50

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 855189b8f51e11f193e23d39c22b90f7af7b6d89